952078 - Keyboard should respect return values that come from InputMethod

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

sendKey on inputmethod is a promise. It can be rejected if a sendKey got canceled, but now we always update the state in keyboard. We should not do that, but rather rely on sendKey return value.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Promisify latin.js

Rudy, can you review? David has a full queue.

This patch uses promises for communicating with inputmethod. This means that:

* If something fails, we won't get a wrong state
* We wait until something is finished before firing the next command

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

This makes the patch a lot cleaner: https://github.com/mozilla-b2g/gaia/pull/14851/files?w=1

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

And this part also fixes bug 951275: https://github.com/mozilla-b2g/gaia/pull/14851/files?w=1#diff-8702d22395c6a86f3d58c20db7020ce8R519

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8350059 [details] [review]
Promisify latin.js

Looks good, r=me.

Jan, thanks for patching this up.

Not sure if it is relevant, while it behaves correctly with this test case, attachment 8349942 [details]:
 1. input 'Teh' and then [Return] key.
 2. => Correct

It would be reverted to Teh + '\n' after you pressed [Backspace].

Comment 5

[Jan Jongboom [:janjongboom] (inactive)]

Yeah we need to land https://bugzilla.mozilla.org/show_bug.cgi?id=952080 (gecko) for that. SendKey always succeeds and thus the state is not correct until we land that.

Comment 6

[Jan Jongboom [:janjongboom] (inactive)]

https://github.com/mozilla-b2g/gaia/commit/857114079b7c82d2915a96f75c01c51a1c3da6c1