952110 - Crash of FF when it installs my extension (HebrewCalendar)

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Igor]

Attachment: hcalendar1.0.6.3-fx+tb.xpi

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36

Steps to reproduce:

I install extension Hebrew Calendar (http://hcalendar.googlecode.com/files/hcalendar1.0.6.3-fx%2Btb.xpi)

links:
extension: http://hcalendar.googlecode.com/files/hcalendar1.0.6.3-fx%2Btb.xpi
crash report: https://crash-stats.mozilla.com/report/index/b8de3476-20b7-4368-b969-f56fe2131217



Actual results:

crash


Expected results:

Extension should be installed and show data in status bar.

Comment 1

[Igor]

Additional notes:
1. Seems, crash started from FF24.
2. When update FF26 to "previous version": installed HebrewCalendar extension works.

Comment 2

[Benjamin Smedberg]

Are you sure this started in FF24 and not FF23? From the crash report, we're crashing here calling strlen on a null pointer: http://hg.mozilla.org/releases/mozilla-release/annotate/39faf812aaec/modules/libjar/nsJAR.cpp#l453

This was changed from a null-safe function (PL_strlen) to strlen in bug 800220, which apparently was in FF23.

Makoto, can you take this?

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Fix

Comment 4

[Igor]

could you advise a workaround: probably, extension HebrewCalendar can be changed to avoid the crash?

Comment 5

[Benjamin Smedberg]

This appears to be an issue with the .xpi signing. You could try not signing it, or somehow signing it differently. I really don't know exactly why this pointer is null.

Comment 6

[Igor]

What do you mean ".xpi signing"? I don't sign the extension with certificate.

Comment 7

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04052f81fa68

Comment 8

[Makoto Kato [:m_kato]]

(In reply to Igor from comment #4)
> could you advise a workaround: probably, extension HebrewCalendar can be
> changed to avoid the crash?

modify META-INF/MANIFEST.MF.  You can fix by adding CRLF to last line.

Comment 9

[Igor]

thank you!
workaround (modify META-INF/MANIFEST.MF.  You can fix by adding CRLF to last line.) works!

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/04052f81fa68