952123 - Improve wait and frame switch after closing the cost control FTU

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Zac C (:zac)]

In the method `run_ftu_accepting_defaults` there is not a very good wait after closing the cost control's FTU. I think this is causing some intermittents.

We should re-jig this to switch back to the main cost control frame and wait for the FTU frame to be closed/destroyed or whatever.

Remove the launch() that is in `run_ftu_accepting_defaults` as this may attempt to reinitialize the app. The displayed_app should be cost control, not the FTU so it should be safe to use that.

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/14896

Comment 2

[Viorela Ioia [:viorela]]

This seems to fix the intermittent problem in Bug 952133 - Investigate intermittent fail in test_cost_control_data_alert_mobile.py: https://pastebin.mozilla.org/3817638

Comment 3

[Zac C (:zac)]

Comment on attachment 8350588 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14896

Logic is fine but just move it into the tap_lets_go method so it's more implicit that we wait.

Comment 4

[Florin Strugariu [:Bebe]]

Comment on attachment 8350588 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14896

Zac's comment

Comment 5

[Zac C (:zac)]

Comment on attachment 8350588 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/14896

r+ thanks!

Comment 6

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/761a7821d6a1a189fc6055469c5f1abf865f7039