952244 - Remember my choice is showing up again on gUM audio permission prompts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Jason Smith [:jsmith]]

The remember my choice option has returned on gUM audio permission prompts. bug 917359 intentionally disabled this for security reasons. It needs to be disabled again on 1.3 in all cases. In 1.4 however, it should only be disabled in the browser, as the required security dependency in bug 945111 has been fixed to allow remember my choice to be enabled in apps.

Comment 1

[Jason Smith [:jsmith]]

For doing the regression window here:

1. Go to http://mozilla.github.io/webrtc-landing/gum_test.html
2. Select Audio

Expected

No remember my choice option in perm prompt.

Actual

Remember my choice option is present in perm prompt.

Comment 2

[J Zimbrick]

Regression Window:

Last Working Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131113040200
Gaia: 7243b75041c93bc7deb240131748d0b164f3f0b0
Gecko: 7b014f0f3b03
Version: 28.0a1
Base Image: V1.2_20131115

First Broken Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20131114143149
Gaia: 4ea5adac92d6a9ab035e708e941d50be0d670da2
Gecko: 7b014f0f3b03
Version: 28.0a1
Base Image: V1.2_20131115

Comment 3

[[e-mail]]

look on it

Comment 4

[Jason Smith [:jsmith]]

bug 936997 seems suspicious for causing this.

Comment 5

[[e-mail]]

I believe the cause is now we are working on `backward compatible mode` in permission manager since bug 853356 is backed out..
The evidence is you'll see 'XXX version < v1.2 does not support...' in console log.

We can wait for bug 853356 landed or add more backward compatible code for this case.

@SC, could I wait for bug 853356 landed?

Comment 6

[Jason Smith [:jsmith]]

(In reply to Fred Lin [:gasolin] from comment #5)
> I believe the cause is now we are working on `backward compatible mode` in
> permission manager since bug 853356 is backed out..
> The evidence is you'll see 'XXX version < v1.2 does not support...' in
> console log.
> 
> We can wait for bug 853356 landed or add more backward compatible code for
> this case.
> 
> @SC, could I wait for bug 853356 landed?

Can't. That bug has no plans to land in 1.3.

Comment 7

[[e-mail]]

Attachment: pull request redirect to github

looks like an easy fix, so add PR for review

Comment 8

[Jason Smith [:jsmith]]

Removing dependency on gUM camera perm prompt as this can't be dependent on that feature, as that will not land for 1.3.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8350434 [details] [review]
pull request redirect to github

Since this happens again I'd like to see any test written for this.

Comment 10

[[e-mail]]

Comment on attachment 8350434 [details] [review]
pull request redirect to github

add testcases, please kindly review it again. Thanks

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: regression of audio prompt.

Comment 12

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/1584816093182199576467b63d8c7e19c035a3a8

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 1584816093182199576467b63d8c7e19c035a3a8 to:
v1.3: af2b5ce2e3887c61d44433d47d17219b9082c705

Comment 14

[Jason Smith [:jsmith]]

lgtm on a 1.3 build from 1/8/2014