Closed
Bug 952285
Opened 11 years ago
Closed 11 years ago
Fix some rooting analysis false positives in TypeRepresentation
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: terrence, Assigned: terrence)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
3.78 KB,
patch
|
nmatsakis
:
review+
|
Details | Diff | Splinter Review |
The three hazards here are false positives: the Object* bits will never be non-null in these stack uses, so the barriers /should/ never fire. The analysis, for obvious reasons of sanity, is not so clever. It (correctly) sees ~TypeRepresentation as a use of the contained object*. I think we should use scoping here to ensure that these stack TypeReprs are *obviously* not live across a GC.
Attachment #8350325 -
Flags: review?(nmatsakis)
|
||
Updated•11 years ago
|
Attachment #8350325 -
Flags: review?(nmatsakis) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/be7ffbe2f336
https://hg.mozilla.org/mozilla-central/rev/be7ffbe2f336
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•