Closed Bug 952285 Opened 9 years ago Closed 9 years ago

Fix some rooting analysis false positives in TypeRepresentation

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: terrence, Assigned: terrence)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

The three hazards here are false positives: the Object* bits will never be non-null in these stack uses, so the barriers /should/ never fire. The analysis, for obvious reasons of sanity, is not so clever. It (correctly) sees ~TypeRepresentation as a use of the contained object*. I think we should use scoping here to ensure that these stack TypeReprs are *obviously* not live across a GC.
Attachment #8350325 - Flags: review?(nmatsakis)
Attachment #8350325 - Flags: review?(nmatsakis) → review+
https://hg.mozilla.org/mozilla-central/rev/be7ffbe2f336
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.