952294 - Image preview tooltips are not shown

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Merih Akar]

When hovered over, image preview tooltips are not being shown in inspector and style rule view in Firefox 29 Nightly. Hovewer they are shown in Firefox 28 Aurora.

Comment 1

[Paul Silaghi, QA [:pauly]]

Please provide a test URL and a screenshot showing the problem.

Comment 2

[Merih Akar]

Attachment: No tooltips for img element (windows)

The mouse cursor is on the src attribute of the img element and the image tooltip is not shown.

Comment 3

[Merih Akar]

Attachment: No tooltips for css background property (windows)

The mouse pointer is on the url part of the background property in style view. No tooltips shown there either.

Comment 4

[Fernando García Gómez, stripTM]

I confirm that this happens on linux and windows

Related bug #945068 ?

Comment 5

[Merih Akar]

I have realized that image preview tooltips are shown as a thin line in Linux.

Comment 6

[Merih Akar]

Attachment: Tooltips appear as thin line for img element (linux)

Comment 7

[Merih Akar]

Attachment: Tooltips appear as thin line for css background property (linux)

Comment 8

[Patrick Brosset <:pbro>]

* Tested on Win7 virtual machine: indeed, image preview tooltip is not shown at all in markup-view and rule-view/computed-view
* On Linux (Ubuntu virtual machine): same, except that a thin 1px wide line is visible
* On Mac: everthing works fine

Tested on a few different sites, so this is global.
Other types of tooltips (e.g. the color picker) seem to work fine though.

My first guess is that the tooltip is here, but has a 0px width.

Comment 9

[Patrick Brosset <:pbro>]

The tooltip widget tries to assign width/height dimensions to the XUL panels in the various setContent function, but it appears to be working a lot better (on linux at least) without these dimensions.
It works too on Mac without them.
So I think the fix for this bug is to remove any call to setSize and add a new test that ensure various tooltips have adequate dimensions when shown.

Comment 10

[Patrick Brosset <:pbro>]

Attachment: bug952294-image-tooltip-hidden-win-linux v1.patch

This patch simply gets rid of the unnecessary setSize(W,H) function calls to let the tooltip panels be sized by their content elements.

It also adds a test case that ensures tooltips are at least as big as their content.

Ongoing try build: https://tbpl.mozilla.org/?tree=Try&rev=9cfa5a1328fb

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8356302 [details] [diff] [review]
bug952294-image-tooltip-hidden-win-linux v1.patch

Review of attachment 8356302 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, just a couple of tiny nits.

r+

::: browser/devtools/inspector/test/browser_inspector_bug_952294_tooltips_dimensions.js
@@ +83,5 @@
> +    let panel = ruleView.previewTooltip.panel;
> +
> +    // Let's not test for a specific size, but instead let's make sure it's at
> +    // least as big as the preview canvas
> +    let w = panel.querySelector("canvas").width;

let canvas = panel.querySelector("canvas");
let w = canvas.width;
let h = canvas.height;

@@ +109,5 @@
> +    let panel = ruleView.previewTooltip.panel;
> +
> +    // Let's not test for a specific size, but instead let's make sure it's at
> +    // least as big as the image
> +    let imageRect = panel.getElementsByTagName("image")[0].getBoundingClientRect();

let imageRect = panel.querySelector("image").getBoundingClientRect();

Comment 12

[Patrick Brosset <:pbro>]

Attachment: bug952294-image-tooltip-hidden-win-linux v2.patch

Corrected the couple of problems raised by Mike.
Applied R+ since these are just Nits.
Launched a new try build: https://tbpl.mozilla.org/?tree=Try&rev=26dfd52f61c9

Comment 13

[Patrick Brosset <:pbro>]

Attachment: bug952294-image-tooltip-hidden-win-linux v3.patch

Sorry, I just attached the wrong patch... I don't know how to HG...
So, here's the new try build: https://tbpl.mozilla.org/?tree=Try&rev=00b814ab8494

Comment 14

[Patrick Brosset <:pbro>]

Try build is green.
R+ by Mike.
Ready to check-in.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/3639d34ce298

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3639d34ce298

Comment 17

[Merih Akar]

Tooltips looks fine in Firefox 29.0a1 (2014-01-09) on Windows 7.