Move some addon-private JSM's to a subdirectory

RESOLVED FIXED in mozilla30

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: WeirdAl, Assigned: WeirdAl)

Tracking

({addon-compat})

Trunk
mozilla30
addon-compat
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Spun off from bug 915838 comment 19:

Third, I think we should consider moving some JSM's around, especially addon-related ones.  resource://gre/modules/ at the top level is getting kind of crowded, and I think certain modules should be in subdirectories of that to distinguish "public" modules (those others are supposed to use) from "private" modules (which addon users should avoid talking to directly).

--

Obvious candidates:
AddonLogging.jsm
AddonRepository.jsm
AddonRepository_SQLiteMigrator.jsm
AddonUpdateChecker.jsm
XPIProvider.jsm
XPIProviderUtils.js

I've also filed bug 952304 for an addon-supporting module, JSONStore.jsm.  That might be a good one to put in a subdirectory as well.
(Assignee)

Comment 1

4 years ago
needinfo? to Unfocused to lay out a roadmap.  Given a roadmap, I can write up a patch fairly quickly (we're talking straight file moves).
Flags: needinfo?(bmcbride)
Ugh, sorry I couldn't get to this before my break.

Modules to make private:

AddonLogging.jsm
AddonRepository.jsm
AddonRepository_SQLiteMigrator.jsm
AddonUpdateChecker.jsm
LightweightThemeImageOptimizer.jsm
PluginProvider.jsm
SpellCheckDictionaryBootstrap.js
XPIProvider.jsm
XPIProviderUtils.js

Lets move them to, say, /toolkit/mozapps/extensions/internal/
And have them accessible via resource://gre/modules/addons/
Which is achievable via setting JS_MODULES_PATH in moz.build
Flags: needinfo?(bmcbride)
AddonRepository.jsm is an odd-duck, in the grey area between being considered public and private. But in practice, it's so very rarely ever used outside of the Add-ons Manager. It's used by only 3 addons on AMO, so lets consider it private and just mark this bug as addon-compat and see if we can get those add-ons updated.
Keywords: addon-compat
OS: Windows 8 → All
Hardware: x86_64 → All
(Assignee)

Updated

4 years ago
Assignee: nobody → ajvincent
(Assignee)

Comment 4

4 years ago
Created attachment 8356965 [details] [diff] [review]
Move some addon-private JSM's to a subdirectory.
Attachment #8356965 - Flags: review?(bmcbride)
Comment on attachment 8356965 [details] [diff] [review]
Move some addon-private JSM's to a subdirectory.

Review of attachment 8356965 [details] [diff] [review]:
-----------------------------------------------------------------

Finally slogging through my huge backlog of non-Australis reviews. Thankfully there's only minimal bitrot here.

Things look a lot cleaner around the place after this patch :) This prompted me to file bug 973752 and bug 973757 for some additional cleanup.
Attachment #8356965 - Flags: review?(bmcbride) → review+
(Assignee)

Comment 6

4 years ago
By the sound of things, I assume whoever's checking this in can handle the bitrot?
Keywords: checkin-needed
Doesn't apply cleanly to fx-team. Please rebase.
Keywords: checkin-needed
(In reply to Alex Vincent [:WeirdAl] from comment #6)
> By the sound of things, I assume whoever's checking this in can handle the
> bitrot?

Generally that would be your job ;) I'll sort that out now and land it.
Status: NEW → ASSIGNED
Unbitrotten, and also removed an unneeded define from each of the moz.build files.

https://hg.mozilla.org/integration/fx-team/rev/400723105403
Backed out in https://hg.mozilla.org/integration/fx-team/rev/a9af498c077d - an impressive toll, but for truly record breaking bustage it would need to not only break all mochitests, reftests, and crashtests, like it did, but also break every flavor of talos and marionette (we haven't had a record breaker since we started doing Cpp tests separate from make check on the build machines, so you don't yet need to break them too for a record).
(Assignee)

Comment 11

4 years ago
Sorry, Blair - I would've gotten to the rebase sooner, but I've recently had dental surgery and I am recovering.
(In reply to Alex Vincent [:WeirdAl] from comment #11)
> Sorry, Blair - I would've gotten to the rebase sooner, but I've recently had
> dental surgery and I am recovering.

No worries :) This is why I'm here. Er, and other reasons too, presumably...

Bored on a Saturday night, may as well figure out why this broke the world.
*sigh* Missed a line when fixing bitrot.

Waiting for a Try push to go green before I shoot myself in the face again:
https://tbpl.mozilla.org/?tree=Try&rev=5c479251318b
Try revealed I also missed updating a new test. 

https://hg.mozilla.org/integration/fx-team/rev/70df8261030a
https://hg.mozilla.org/mozilla-central/rev/70df8261030a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30

Comment 16

4 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f44512993d0fc8229eb3df256a85b80ce619dfb0
Bug 952307 - Move some addon-private JSM's to a subdirectory. r=Unfocused

Updated

4 years ago
Depends on: 977078
You need to log in before you can comment on or make changes to this bug.