952373 - [build script] should rename HOMESCREEN to SYSTEMAPP in gaia build script

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

The "homescreen" variable in Makefile and preferences.js is actually pointing to system app.

https://github.com/mozilla-b2g/gaia/blob/master/Makefile#L125
https://github.com/mozilla-b2g/gaia/blob/master/build/preferences.js#L16

Comment 1

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/14882

Hi Yuren, 
   please help to review my patch.
Thanks

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

+++++++

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

I believe we should change this as well...
http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/shell.js#193

Comment 4

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi Fabrice,
   As Alive mentioned on comment #3, this is good timing to use 'browser.startupURL' instead of 'browser.homescreenURL', since 'homescreen' is not a first launch app in FxOS.

   Do you have any suggestion about this patch?

   If we want to rename 'browser.homescreenURL', there are two patch for this issue, one is gaia patch and the other is gecko patch. How do we land this patch at the same time?

   Thanks. ;)

Comment 5

[[:fabrice] Fabrice Desré]

Hi Gary, thanks for cleaning up that!

This should not even be browser.* I think. Ideally we would do have a single preference that gives us the manifest url of the system app, and build the starting url from there. But that means waiting for the DOM application registry to be ready, which is slowing down startup. So let's keep both prefs, with some renaming:

remove support for B2G_HOMESCREEN, since it's not enough by itself anyway.
browser.manifestURL -> b2g.system_manifest_url
browser.homescreenURL -> b2g.system_startup_url

As for landing this kind of changes, we can't do atomic gecko+gaia landings, so we usually proceed like this:
- land a change in gecko that supports both the old way and the new one.
- once this change is in m-c, land the gaia change.
- finally, land the gecko change to remove support for the old way.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8350518 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/14882

Hi Gary,

set review flag to me again if you are ready for gecko + gaia part!

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

we are stuck on here 5 months, I suggest to land the gaia part first and file a follow up bug to clean up the pref between gaia & gecko.

Gary, could you rebase and send review request again?

Comment 9

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Okay, I just file another bug for gecko part. bug 1013094.

Comment 10

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/19418

Hi Yuren,
   Please help to review this patch, sorry about late for this patch.
   
   Thanks.

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8425305 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/19418

r=yurenju but please file a follow up bug for removing 'browser.homescreenURL'

Comment 12

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

landed in gaia:
https://github.com/mpizza/gaia/commit/b787a158293f84f68f8c89b845c6f7bf77e94add

travis got green:
https://travis-ci.org/mozilla-b2g/gaia/builds/25839308