[build script] should rename HOMESCREEN to SYSTEMAPP in gaia build script

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: schien, Assigned: GaryChen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=yurenju])

Attachments

(2 attachments)

Assignee: nobody → gchen
Status: NEW → ASSIGNED
Whiteboard: [mentor=yurenju]
Created attachment 8350518 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/14882

Hi Yuren, 
   please help to review my patch.
Thanks
Attachment #8350518 - Flags: review?(yurenju.mozilla)
+++++++
Hi Fabrice,
   As Alive mentioned on comment #3, this is good timing to use 'browser.startupURL' instead of 'browser.homescreenURL', since 'homescreen' is not a first launch app in FxOS.

   Do you have any suggestion about this patch?

   If we want to rename 'browser.homescreenURL', there are two patch for this issue, one is gaia patch and the other is gecko patch. How do we land this patch at the same time?

   Thanks. ;)
Flags: needinfo?(fabrice)
Hi Gary, thanks for cleaning up that!

This should not even be browser.* I think. Ideally we would do have a single preference that gives us the manifest url of the system app, and build the starting url from there. But that means waiting for the DOM application registry to be ready, which is slowing down startup. So let's keep both prefs, with some renaming:

remove support for B2G_HOMESCREEN, since it's not enough by itself anyway.
browser.manifestURL -> b2g.system_manifest_url
browser.homescreenURL -> b2g.system_startup_url

As for landing this kind of changes, we can't do atomic gecko+gaia landings, so we usually proceed like this:
- land a change in gecko that supports both the old way and the new one.
- once this change is in m-c, land the gaia change.
- finally, land the gecko change to remove support for the old way.
Flags: needinfo?(fabrice)
Comment on attachment 8350518 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/14882

Hi Gary,

set review flag to me again if you are ready for gecko + gaia part!
Attachment #8350518 - Flags: review?(yurenju.mozilla)
Component: Gaia → Gaia::Build
we are stuck on here 5 months, I suggest to land the gaia part first and file a follow up bug to clean up the pref between gaia & gecko.

Gary, could you rebase and send review request again?
Flags: needinfo?(gchen)
Duplicate of this bug: 1012591
Okay, I just file another bug for gecko part. bug 1013094.
No longer blocks: 1013094
Flags: needinfo?(gchen)
Created attachment 8425305 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/19418

Hi Yuren,
   Please help to review this patch, sorry about late for this patch.
   
   Thanks.
Attachment #8425305 - Flags: review?(yurenju.mozilla)
Depends on: 1013094
Comment on attachment 8425305 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/19418

r=yurenju but please file a follow up bug for removing 'browser.homescreenURL'
Attachment #8425305 - Flags: review?(yurenju.mozilla) → review+
No longer blocks: 1014487
landed in gaia:
https://github.com/mpizza/gaia/commit/b787a158293f84f68f8c89b845c6f7bf77e94add

travis got green:
https://travis-ci.org/mozilla-b2g/gaia/builds/25839308
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.