952375 - UnionConversions should include headers for external interfaces too

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

In particular, otherwise we don't even know that they inherit from nsISupports, and bad things happen.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Include headers for external interfaces in UnionConversions.h.

Comment 2

[David Zbarsky (:dzbarsky)]

Comment on attachment 8350455 [details] [diff] [review]
Include headers for external interfaces in UnionConversions.h.

Review of attachment 8350455 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/Codegen.py
@@ +882,5 @@
> +                            try:
> +                                typeDesc = p.getDescriptor(f.inner.identifier.name)
> +                            except NoSuchDescriptorError:
> +                                continue
> +                            headers.add(typeDesc.headerFile)

Do external interfaces have a worker/non-worker distinction?  Or can we just use the first provider found?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Do external interfaces have a worker/non-worker distinction?

In general, yes.  Hopefully we can just kill off external interfaces soon...

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9494599831b1

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9494599831b1