[Video] Update toolbars to use building blocks

NEW
Unassigned

Status

Firefox OS
Gaia::Video
4 years ago
3 years ago

People

(Reporter: epang, Unassigned)

Tracking

unspecified
x86
Gonk (Firefox OS)

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: visual design, visual-tracking, bokken [priority])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Once bug 947093 lands we should use the building blocks to update the toolbar in video.  Thanks!

Updated

4 years ago
Assignee: nobody → johu
blocking-b2g: --- → 1.4?
Hi Eric,

I found two files, Toolbars1_VisualSpec-Part2_Nov22.png and Toolbars1_VisualSpec-Part3_Nov18.png, in Spec of bug 947093 are related to this bug. And the bug 947103 is dealing with that. So, I need to know which parts are missing and need to be fixed in this bug.
Flags: needinfo?(epang)
(Reporter)

Comment 2

4 years ago
Created attachment 8359244 [details]
Video Specs.zip

Hi John,
Thanks for working on this.  I've attached the two relevant specs to this bug.  
1. The video play refresh
2. The video tool bar update (dark toolbar)

I'm not sure what Pavel has already finished, Pavel can you help John out and let him know what's left to do?  Also, I'm not sure if we still need bug 947103 if we can update to the refreshed video player and the dark toolbars in one bug.

Thanks!
Eric
Flags: needinfo?(epang) → needinfo?(pivanov)
Hey guys,

I think my patch is obsolete ... but we can use it as reference for the  point one "The video play refresh"
The video tool bar update is the next part of this bug ... unfortunately I don't know any spec for the tablet version and I'm not sure how can I test it (maybe I need a device) ... but if I can help with something just ping me.
Flags: needinfo?(pivanov)
Thanks Pavel.

I can help to finish the tablet part and send you my patch. So, let start from the bug 947103 and come back to toolbars here.
Great :) thanks

Comment 6

4 years ago
johu, was there any work done on this bug since the last update? (we probably need to move this into 1.5 given there are other high priority items)
Flags: needinfo?(johu)
Sorry Hema,

I haven't start it, yet.
Flags: needinfo?(johu)
I will find someone to handle this one.
Assignee: johu → nobody
(Reporter)

Comment 9

4 years ago
(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #8)
> I will find someone to handle this one.

Thanks John!
Moving to backlog - VD refresh issues won't block the release.
blocking-b2g: 1.4? → backlog

Updated

4 years ago
Whiteboard: visual design, visual-tracking, bokken → visual design, visual-tracking, bokken [priority]
(Assignee)

Updated

3 years ago
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.