Thumbnail in about:newtab for Web pages behind HTTP Authentication shows image of the "401 Authentication Required" page

NEW
Unassigned

Status

()

5 years ago
3 years ago

People

(Reporter: freddyb, Unassigned)

Tracking

(Depends on: 1 bug)

Trunk
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: p=0)

(Reporter)

Description

5 years ago
One of my top websites is behind HTTP authentication, but the thumbnail only shows the 401 web page that you get when your password is wrong and not the actual web page.

It looks like the background thumbnailer does not check the response code.

Comment 1

5 years ago
The background thumbnailer never overwrites existing thumbnails, so it only captures the page if there's not already a thumbnail for it.  It'll capture even non-2xx pages under the assumption that non-2xx thumbnails are better than no thumbnails at all.

Once you visit the page -- two days later -- the foreground thumbnailer captures a thumbnail showing the page as you see it.  That "two days later" part is a staleness check and means that bad background thumbnails aren't overwritten as soon as they could be.  We might want to fix that.

Comment 2

5 years ago
Oh, there's expiration, too: Thumbnails expire after a certain amount of time and are deleted.  So a nice thumbnail can expire and then a bad background thumbnail might be captured soon after.  Bug 809056 made it so only top sites are captured and stored, but it kept the status quo of expiring thumbnails for all pages that aren't open when the expiration filter runs.  We should probably make it not expire top sites.

Updated

5 years ago
Depends on: 960941

Updated

5 years ago
Blocks: 950073
Whiteboard: [triage]

Updated

5 years ago
Whiteboard: [triage]

Updated

5 years ago
Whiteboard: p=0

Updated

4 years ago
Depends on: 1013355

Updated

4 years ago
No longer blocks: 950073
Flags: firefox-backlog+

Updated

4 years ago
Component: General → General
Product: Core → Toolkit
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.