Login Server Admin Console Still Broken

RESOLVED FIXED

Status

Webmaker
Login
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cade, Assigned: cade)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The Javascript was never updated to reflect the changes in the API routes.
(Assignee)

Updated

4 years ago
Blocks: 949974
(Assignee)

Comment 1

4 years ago
Created attachment 8350635 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/226
Attachment #8350635 - Flags: review?
(Assignee)

Comment 2

4 years ago
Comment on attachment 8350635 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/226

I fixed the original search input box and button, and added a second pair to allow us to also find by email address.
Attachment #8350635 - Flags: review? → review?(jon)
(Assignee)

Updated

4 years ago
Attachment #8350635 - Flags: review?(jon) → review?(kieran.sedgwick)
Comment on attachment 8350635 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/226

r+ with major nit, noted in the PR
Attachment #8350635 - Flags: review?(kieran.sedgwick) → review+
(Assignee)

Comment 4

4 years ago
Comment on attachment 8350635 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/226

I found some other lingering issues, please take another look.
Attachment #8350635 - Flags: review+ → review?(kieran.sedgwick)
Comment on attachment 8350635 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/226

Good catch on that one. Weird that I missed it :/
Attachment #8350635 - Flags: review?(kieran.sedgwick) → review+

Comment 6

4 years ago
Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/6a8526d929ba3b4236ed67639e6b613ae78b77fe
Bug 952481 - Fix username search on Login console, enable separate email search input.
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.