952481 - Login Server Admin Console Still Broken

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[Chris DeCairos (:cade)]

The Javascript was never updated to reflect the changes in the API routes.

Comment 1

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/226

Comment 2

[Chris DeCairos (:cade)]

Comment on attachment 8350635 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/226

I fixed the original search input box and button, and added a second pair to allow us to also find by email address.

Comment 3

[Kieran Sedgwick (:sedge)]

Comment on attachment 8350635 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/226

r+ with major nit, noted in the PR

Comment 4

[Chris DeCairos (:cade)]

Comment on attachment 8350635 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/226

I found some other lingering issues, please take another look.

Comment 5

[Kieran Sedgwick (:sedge)]

Comment on attachment 8350635 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/226

Good catch on that one. Weird that I missed it :/

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/6a8526d929ba3b4236ed67639e6b613ae78b77fe
Bug 952481 - Fix username search on Login console, enable separate email search input.