952489 - USA phone numbers from contact list not recognized

Status: RESOLVED INCOMPLETE

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[fai]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36

Steps to reproduce:

I am using the ZTE Open with FFOS 1.1 in the USA. When someone from the contact list calls me, the phone number would not be matched with the associated contact unless the number in contact list is saved exactly in this format: 1(area code)(phone number), such as: 12121111111. Where as all the phone I've used in the past 10 years would be able to match the contact even when the "1" in front is omitted, such as: 2121111111.


Actual results:

Caller Id would not show with contact information even the number is already on the contact list.


Expected results:

In coming call should still be recognized even if the country code "1" is omitted.

Comment 1

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Not sure is there is a bug for this already - flagging ni? Naoki - anyone else, feel free to flag as dupe if there is one on file.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Hrm.  this is odd.. I'll have to look into this.  bug 881248 says it's fixed in 1.1... Thanks Andrew.

[e-mail]; can you check what your build id / gaia revision is for me please?  You should be able to find it in the device info -> more info section.

Comment 3

[fai]

OS version:1.1.0.0
Firmware revision:01.01.00.019.215
Platform version:18.1
Build Identifier:
20131204161642

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Supposedly it should be in the build, unless it wasn't picked up or it is a regression.  I'll dig further into it.  Thanks fai.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I can't seem to reproduce getting a 1 in front ... on ikura 1.1

nhirata-19333:B2G_flash_tool nhirata$ ./check_versions.sh 
Gaia      c7fd105fa5ba527352736db28434690269fb70c1
Gecko    
BuildID   20131204161642
Version   18.0
ro.build.version.incremental=eng.zhangchun.20131204.155720
ro.build.date=Wed Dec  4 15:57:35 CST 2013

Does it have to be an out of state/country number that calls you in order to get this to happen?

Comment 6

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

I'm in Canada but the only time I get the extra one in front are when I get spam calls and they # they have the 1 pre-inserted in their outgoing number (caller id number) I guess.

Comment 7

[fai]

I don't think it's an out of state/country issue here. Let's say someone calls in and his number would show on the caller id as 17181111234. It would only show with the name only if I have this number stored in the contact list exactly like it is as in 17181111234. If I have this number on my contact list and it's stored as 7181111234, then incoming call would not be recognized and I would only see the number.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Thanks for the additional info.  I will reinvestigate.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

So I still can't reproduce getting the 1 in front of the number when receiving a call.  I know that in Canada the number 1 does appear as it differentiates a call that is made to the US versus in Canada.

I won't be able to confirm this.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Hei Gregor,

is this a problem with libphonenumber? Can you reproduce it?

Thx!

Comment 11

[Gregor Wagner [:gwagner]]

This should work and we have tests for it. Maybe the country detection code is buggy and we don't recognize the country.

Comment 12

[Johan Lorenzo [:jlorenzo] - PTO - Back August 24th]

I don't remember seeing this kind of issue when I was in the US either. Naoki wasn't able to reproduce at the time. We started the dogfooding program in last June so I would expect to have duplicates of this bug since.

I think it's safe to close this issue today.