952610 - Bookmark installation test failure

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

1) Install bookmark on homescreen > Navigate to sample.html and bookmark it on homescreen "before each" hook:

NoSuchElement: (7) Unable to locate element: .inline-activity.active > iframe[mozbrowser]

Remote Stack:

<none>

at Error.MarionetteError (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/error.js:67:13)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:474:19)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:508:21

at TcpSync.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:94:10)

at Object.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:455:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:501:19)

at Object._findElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1283:19)

at Object.findElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1332:32)

at Object.currentTabFrame (/home/travis/build/mozilla-b2g/gaia/apps/homescreen/test/marionette/lib/bookmark_editor.js:29:24)

at Object.BookmarkEditor.backToApp (/home/travis/build/mozilla-b2g/gaia/apps/homescreen/test/marionette/lib/bookmark_editor.js:35:35)

at Object.Homescreen.switchToBookmarkEditorFrame (/home/travis/build/mozilla-b2g/gaia/apps/homescreen/test/marionette/lib/homescreen.js:66:25)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/homescreen/test/marionette/install_bookmark_test.js:67:18)

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:211:32)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:257:10)

at Object._onImmediate (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:274:5)

at processImmediate [as _immediateCallback] (timers.js:330:15)

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Is this a new test or an existing one?

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

It's my bad so please let me fix it.

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Weird, it's all green with 20 runs on Travis

https://travis-ci.org/mozilla-b2g/gaia/builds/15869335

Comment 4

[Ben Francis [:benfrancis]]

I don't have any further information, can this be closed?

Comment 5

[Dietrich Ayala (:dietrich)]

Can you add a patch to re-enable the test? Let's turn it back on and see what happens.

Comment 7

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request to re-enable test

Hi Dietrich,

I made a PR here to re-enable the test.
Also I made homescreen marionette JS test to run 20 times and they all ran well.
https://travis-ci.org/mozilla-b2g/gaia/builds/18331051

I am wondering whom do I ask for review?

Comment 8

[Dietrich Ayala (:dietrich)]

https://wiki.mozilla.org/Modules/FirefoxOS#Gaia

For homescreen, ask Christian or Vivien.

Comment 9

[Dietrich Ayala (:dietrich)]

Comment on attachment 8371334 [details] [review]
pull request to re-enable test

f+, I also ran it a bunch of times without error. You need r+ from a module owner/peer to land though :)

Comment 10

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8371334 [details] [review]
pull request to re-enable test

Hi Vivien,

we are about to re-enable bookmark installation marionette JS test. Would you like to review it? Thanks

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8371334 [details] [review]
pull request to re-enable test

Christian is probably more accurate for this test.

Comment 12

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8371334 [details] [review]
pull request to re-enable test

Go ahead, it works fine in my computer and in Travis. Thanks

Comment 13

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Thanks,

Landed on master https://github.com/mozilla-b2g/gaia/commit/b449aa849b471cda9525a4fa6931637f1523e9fd