952616 - OdinMonkey: tweak success message when not stored in cache

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Luke Wagner [:luke]]

Attachment: tweak-caching-message

This patch tweaks the asm.js success message to say "not stored in the cache" when the compiled module is not stored in the cache.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8350747 [details] [diff] [review]
tweak-caching-message

Review of attachment 8350747 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/AsmJS.cpp
@@ +1709,5 @@
>              }
>          }
>          out->reset(JS_smprintf("total compilation time %dms%s%s",
>                                 msTotal,
> +                               storedInCache ? "; stored in cache" : "; not stored in cache",

You could even factorize the "; " in the first argument ("total compilation time %dms; %s%s") and thus reduce the size of these strings, but that nitpicking seems to be only worth 2 bytes :)

Comment 2

[Luke Wagner [:luke]]

I'll take it :)
https://hg.mozilla.org/integration/mozilla-inbound/rev/32724614e323

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/32724614e323

Comment 4

[Luke Wagner [:luke]]

Oops, I hoisted the semicolon into the wrong place:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cf7c629cfcd

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1cf7c629cfcd