952691 - [B2G][Contacts][Facebook Sync]Contacts imported from Facebook do not sync every 24 hours to reflect profile changes.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Ross Kuhlman ([e-mail])]

Any contacts that are synced to facebook must update every 24 hours to reflect changes made to the Facebook profile. The contacts do not update. 

Repro Steps:
1) Updated Buri to Build ID: 20131219004002
2) Launch Contacts App and import a profile from facebook.
3) Use PC to log into imported facebook profile and make alterations. (ex: set ph# from public to private)
4) Wait 24 hours and then open the contacts app.

Actual:
Facebook details do not update after 24 hours.

Expected:
After 24 hours the automatic Facebook sync should update and reflect changes made on the profile.

Environmental Variables
Device: Buri v1.3 Moz RIL
Build ID: 20131219004002
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/809aabadac6d
Gaia: a99249a7fdf9f20850d98a9a222385676d472362
Platform Version: 28.0a2
Firmware Version: V1.2_20131115

Notes:
Repro frequency: 100%

Comment 1

[Ross Kuhlman ([e-mail])]

I tried editing the config.json file to automatically sync contacts every 5 minutes. 30 minutes later, no changes have been observed in the contacts.

File modified:
system/b2g/webapps/communications.gaiamobile.org/applications.zip/Contacts/config.json

Comment 2

[Jason Smith [:jsmith]]

Does this reproduce on 1.2?

Comment 3

[Ross Kuhlman ([e-mail])]

This issue also occurs in 1.2

Environmental Variables
Device: Buri v1.2 Moz RIL
Build ID: 20131218004002
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/dcffefec8206
Gaia: 38338b31b554cdb8c6242b15a966f171a0e7abaa
Platform Version: 26.0
Firmware Version: v1.2_20131115

I will add another update tomorrow to determine if this happens in 1.1 (need to wait 24 hrs to be sure)

Comment 4

[pfield]

This issue does not occur in V 1.1.0

Environmental Variables
Device: Buri v 1.1.0 Mozilla
Build ID: 20140102041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/bdac595a4e46
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Platform Version: 18.1
RIL Version: 01.02.00.019.102

Comment 5

[Jason Smith [:jsmith]]

Sounds like a broken experience with facebook integration then.

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3+ regrssion

Comment 7

[Jose Manuel Cantera]

I cannot reproduce this. How do you test that the sync ids working. Are you changing the profile photo to a different one? Are you chaning some Friend data?

How do you configure the timeout for sync? 

In any case please attach the log files. 

thanks

Comment 8

[Ross Kuhlman ([e-mail])]

Attachment: log.txt

To determine whether data was being updated or not, I would set all of the friend profile's info to be private (phone number, email address, home address) when the profile is downloaded to the device. Afterwards, I set all of the private info to be public. After syncing, this now-public info should be copied to the contact info on the device.

As for configuring the sync timeout, I tried three methods, all without success. I manually changed the date on the device to be 24 hours in the future. I also tried simply waiting 24 hours and checking the device again. Lastly, I tried to reconfigure the config.json file to update every 5 minutes, using the steps demonstrated here: https://docs.google.com/a/qanalydocs.com/document/d/1EFaEKo-YskzU7RoilIZsQmTfnLwwEPJEZtxN8O-Mc7A/edit
In all three situations, the profile info was not updated.

I have attached a logcat of the user manually changing the date, and Facebook not updating the profile information.

Comment 9

[Jose Manuel Cantera]

Seeing your logs, the alarm is properly raised. I cannot reproduce it in my environment

Please could you try with a simpler use case, for instance changing the Friend's photo?

thanks

Comment 10

[Ross Kuhlman ([e-mail])]

Attachment: logcat of FB profile pic changing.

The Profile picture is being updated when the date is changed. 
Repro Steps:
1) Download FB profile to device.
2) Change FB profile picture on a different computer.
3) Manually adjust the date on the device to be one day in the future.
Result:
Profile picture on device is updated properly.

Comment 11

[Jose Manuel Cantera]

mmmm then the sync process is working properly. Can you check that other fields, email, phone, address are properly updated? If so, there can an issue on the FB side that does not consider a user as updated when changing info from private to public and viceversa. 

Can you test also changing the field visibility and then change photo and see what happens? if all the public info is updated properly?

thanks

Comment 12

[Ross Kuhlman ([e-mail])]

Attachment: All Facebook Details Changed From Private To Public Log

It appears that the only profile setting that is updated is the profile image. I set every possible setting to be private, and downloaded the profile to my device. Afterwards, I modified the profile to make every possible setting public. Then I adjusted the date on my device to force an update. Upon examining the Facebook contact, only the image had changed. No new information appears to have been downloaded.

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140109004002
Gaia: 22bc6be5b76cdc6d4e9667ff070979041a20ce2f
Gecko: 2c8f8683bd0d
Version: 28.0a2
Firmware Version: 20131115

SIDE NOTE: while doing this, I also noticed that 'work' phone numbers on the profile are saved on the device as 'personal' phone numbers.

Comment 13

[Jose Manuel Cantera]

(In reply to rkuhlman from comment #12)
> Created attachment 8358649 [details]
> All Facebook Details Changed From Private To Public Log
> 
> It appears that the only profile setting that is updated is the profile
> image. I set every possible setting to be private, and downloaded the
> profile to my device. Afterwards, I modified the profile to make every
> possible setting public. Then I adjusted the date on my device to force an
> update. Upon examining the Facebook contact, only the image had changed. No
> new information appears to have been downloaded.

I will try to reproduce this situation myself. 

> 
> 1.3 Environmental Variables:
> Device: Buri 1.3 MOZ
> BuildID: 20140109004002
> Gaia: 22bc6be5b76cdc6d4e9667ff070979041a20ce2f
> Gecko: 2c8f8683bd0d
> Version: 28.0a2
> Firmware Version: 20131115
> 
> SIDE NOTE: while doing this, I also noticed that 'work' phone numbers on the
> profile are saved on the device as 'personal' phone numbers.

That's the desired behaviour. Although once bug 925566 lands all FB info will be categorized as 'other' (as requested by UX). 

thanks for the help and testing

Comment 14

[Matthew Vaughan]

This issue looks to have started reproducing on the 08/26/13 1.2 build.

This issue reproduces on the first working 1.3 build from 09/19/13. When 1.2 became Aurora (master was 1.3), this issue stopped reproducing on the 1.2 build. Therefore it appears this issue went from 1.2 to 1.3 on the master branch.

** The 08/25/13 1.2 build is broken **

- Works -
Environmental Variables:
Device: Buri v1.2 MOZ RIL
BuildID: 20130824040225
Gaia: 42d88f26420b6c58621d1b68675d512fd10c9fcb
Gecko: 17143a9a0d83
Version: 26.0a1
Firmware Version: V1.2_US_20131115

- Broken -
Environmental Variables:
Device: Buri v1.2 MOZ RIL
BuildID: 20130826163255
Gaia: 23343e6ea3cc59c3ab0ac9188aaa657bd11da4fd
Gecko: 14b1e8c2957e
Version: 26.0a1
Firmware Version: V1.2_US_20131115

Comment 15

[Jose Manuel Cantera]

I've been testing this with latest builds I can't repro it. Please could you check is reproducible in your latest 1.3 builds? We've been landing serveral bugs in FB and datastore that probably have fixed any issue related to this

thanks!

Comment 16

[Ross Kuhlman ([e-mail])]

I am still seeing the issue in todays build. I changed the profile picture, phone number, and hometown on 
a friend profile. I saved the changes, then manually adjusted the date on my device to one day in the future. On my device, the profile picture is updated, but the phone number and hometown did not change.

Environmental Variables:
Device: Buri v1.3 Moz RIL
BuildID: 20140131004001
Gaia: 0ddcd8da5bfe1b48c73502ef29220e92f2db6b73
Gecko: 32e45047b663
Version: 28.0a2
Firmware Version: v1.2-device.cfg

Comment 17

[Jason Smith [:jsmith]]

(In reply to rkuhlman from comment #16)
> I am still seeing the issue in todays build. I changed the profile picture,
> phone number, and hometown on 
> a friend profile. I saved the changes, then manually adjusted the date on my
> device to one day in the future. On my device, the profile picture is
> updated, but the phone number and hometown did not change.
> 
> Environmental Variables:
> Device: Buri v1.3 Moz RIL
> BuildID: 20140131004001
> Gaia: 0ddcd8da5bfe1b48c73502ef29220e92f2db6b73
> Gecko: 32e45047b663
> Version: 28.0a2
> Firmware Version: v1.2-device.cfg

Did you make sure to kill & restart the contacts app when changing the date into the future?

Comment 18

[Ross Kuhlman ([e-mail])]

Attachment: FacebookProfileUpdateDetails.txt

Now with repro steps:

Prerequisites: Have access to two Facebook profiles, Profile A and Profile B. A and B must be friends with each other. Have a FxOS device that is not associated with any Facebook account.

1) On a PC, sign into Profile B, navigate to 'Edit Profile' and ensure that EVERY profile detail is filled out and set to 'Private'. Save any changes.
2) On FxOS device, launch Contacts app, sign into Profile A, and import Profile B from Facebook to your device.
3) On FxOS device, observe contact details for Profile B.
4) On PC, navigate to 'Edit Profile' and set EVERY profile detail to 'Public', and change profile picture. Save all changes.
5) On FxOS device, launch Settings app and manually adjust device date to be one day in the future.
6) On FxOS device, launch Contacts app and observe contact details for Profile B.

Actual Result:
Profile picture is updated, but all other contact details are unaffected.

Expected Result:
Profile picture is updated, and public content is now displayed on device.

Notes:
The profile information will be properly presented if the contact is manually deleted and then re-imported.

Comment 19

[Ross Kuhlman ([e-mail])]

In reply to question from comment 17:

I tried both options: 
1) Force close contacts app, manually adjust date, relaunch contacts app.
2) Manually adjust date while contacts app is still open.

In both cases, the contacts details are not updated. I had to manually delete the contact and re-import it in order to update the details.

Comment 20

[Jose Manuel Cantera]

There is an old Facebook bug concerning changes in the visibility mode which are not counted as changes when we ask for synchronization. Please, could you test this bug by making changes in data and not in its visibility?

Comment 21

[Jason Smith [:jsmith]]

(In reply to Jose M. Cantera from comment #20)
> There is an old Facebook bug concerning changes in the visibility mode which
> are not counted as changes when we ask for synchronization. Please, could
> you test this bug by making changes in data and not in its visibility?

Can you clarify this a bit more? I'm having some difficulty following what is meant by data changes vs. visibility.

Comment 22

[Jose Manuel Cantera]

(In reply to Jason Smith [:jsmith] from comment #21)
> (In reply to Jose M. Cantera from comment #20)
> > There is an old Facebook bug concerning changes in the visibility mode which
> > are not counted as changes when we ask for synchronization. Please, could
> > you test this bug by making changes in data and not in its visibility?
> 
> Can you clarify this a bit more? I'm having some difficulty following what
> is meant by data changes vs. visibility.

Changing visibility of data means changing the protection level (private, public, friends-only, etc.). Changing data means changing the data itself, such as changing your phone number, company name and the like.

Comment 23

[Kai-Chih Hu [:khu]]

Can we get ETA to fix this bug? Thank you.

Comment 24

[Jose Manuel Cantera]

I have my doubts this is a real bug on Gaia side. The situation described by the reporter seems to describe a FB Platform bug. But we need more input from the reporter asap.

thanks

Comment 25

[Jason Smith [:jsmith]]

Can we get a detailed clarification of what's the difference here in terms of behavior on 1.1 vs. 1.3?

Comment 26

[Marcia Knous [:marcia]]

marcia to work offline to get a clear data set regarding behavior.

Comment 27

[Matthew Vaughan]

(In reply to Jason Smith [:jsmith] from comment #25)
> Can we get a detailed clarification of what's the difference here in terms
> of behavior on 1.1 vs. 1.3?

Please follow this link to a Google spreadsheet outlining what is seen in the 02/05/14 1.1 versus the 02/03/14 1.3 builds. I tested changing the visibility and the actual data of just about everything (even the contact data that isn't shown in the Contacts app). Overall, 1.1 updated as expected and 1.3 did not.

https://docs.google.com/a/qanalydocs.com/spreadsheet/ccc?key=0Am7r1cdVu7ZodDNKTVBwSE81Vm1IMlBkYmpSZmM2aXc&usp=drive_web#gid=0

Comment 28

[Jason Smith [:jsmith]]

Jose - Does the spreadsheet analysis help here?

Comment 29

[Jose Manuel Cantera]

Attachment: 16024.html

Comment 30

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8371309 [details]
16024.html

Good job!

Comment 31

[Jose Manuel Cantera]

master: 

https://github.com/mozilla-b2g/gaia/commit/0417f87b62b9b7ebbc48c1e9e1e3a144e0b64d70

Comment 32

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 0417f87b62b9b7ebbc48c1e9e1e3a144e0b64d70 to:
v1.3: fffc09cf456a1bf715f8f060a54c3624b6df9e64