Sync progress screen uses a Gingerbread progress bar

RESOLVED FIXED

Status

()

Firefox for Android
Android Sync
RESOLVED FIXED
4 years ago
2 months ago

People

(Reporter: Veeti Paananen, Assigned: Veeti Paananen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20131221030204

Steps to reproduce:

Associate install with a sync account


Actual results:

The progress screen uses an ugly progress bar


Expected results:

The progress screen uses a standard "Holo" progress bar
(Assignee)

Comment 1

4 years ago
Created attachment 8350940 [details] [diff] [review]
952789.patch

Updated

4 years ago
Component: General → Android Sync
Product: Firefox for Android → Android Background Services
Version: Trunk → unspecified

Updated

4 years ago
Attachment #8350940 - Flags: review?(nalexander)

Updated

4 years ago
Assignee: nobody → veeti.paananen
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8350940 [details] [diff] [review]
952789.patch

Review of attachment 8350940 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  I see no other users of Widget.ProgressBar, so this shouldn't bust anybody else.  I'll land this upstream in the android-sync repo and update this ticket accordingly.

Thanks for the contribution, and sorry for the slow review!
Attachment #8350940 - Flags: review?(nalexander) → review+
OS: Linux → Android
Hardware: x86_64 → All
https://hg.mozilla.org/integration/mozilla-inbound/rev/707c397f0069
https://github.com/mozilla-services/android-sync/compare/475784bdebd8...4bcd94b6d4ae
https://hg.mozilla.org/mozilla-central/rev/707c397f0069
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

2 months ago
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.