[Usage][l12y] wifi-usage and mobile-usage are reused in different contexts

RESOLVED FIXED

Status

Firefox OS
Gaia::Cost Control
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tchevalier, Assigned: tchevalier)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The strings wifi-usage and mobile-usage are used in different contexts. (Chart view and settings).
Localizers may want to adjust the size in each view, there is more room in settings and it looks weird to have shortened strings there.
(Assignee)

Comment 1

4 years ago
Created attachment 8351028 [details] [review]
Link to Github PR

I'm not very happy with the comment. Francesco, what do you think?
Attachment #8351028 - Flags: feedback?(francesco.lodolo)
What about just:

> # LOCALIZATION NOTE (wifi-usage-settings, mobile-usage-settings): these strings 
> # are displayed in the Settings section

I would also add a similar comment for the existing strings (wifi-usage, mobile-usage), saying that they're displayed in the main window. No need to explain we're talking about Usage, since strings are per app.
Attachment #8351028 - Flags: feedback?(francesco.lodolo)
(Assignee)

Comment 3

4 years ago
Comment on attachment 8351028 [details] [review]
Link to Github PR

Thanks Francesco.

Salvador, could you take a look please? :)
Attachment #8351028 - Flags: review?(salva)
Comment on attachment 8351028 [details] [review]
Link to Github PR

I like it. Go on and thank you. Can you merge or do you need me? Ping me if so.
Attachment #8351028 - Flags: review?(salva) → review+
(Assignee)

Comment 5

4 years ago
(In reply to Salvador de la Puente González [:salva] from comment #4)
> Comment on attachment 8351028 [details] [review]
> Link to Github PR
> 
> I like it. Go on and thank you. Can you merge or do you need me? Ping me if
> so.

Thanks!

Need you :) (I don't have rights)
Master: 84d34f650885f2e37c1b445ff1109a0c422b0324
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.