952869 - LoginManager should defer/lazify reading/decrypting password property as late as possible

Status: NEW

(Toolkit :: Password Manager, defect, P3)

Description

[Julian Fitzell]

LoginManager checks the length of the password for every login (I think as a result of Bug 391514). This is fine with the default storage implementation, but is potentially undesirable for other implementations.

In particular, the Apple Keychain requires authorization to access the password field but allows unrestricted access to all others. If a user has multiple accounts stored for a site and has not decided to "Always allow" access to Firefox, they will be prompted for access to every password on each autofill attempt, even if the username does not match what has been entered in the form.

It would be nice if we could defer checking the password length until we've filtered the list of logins and are otherwise sure the password could be filled.

Comment 1

[Julian Fitzell]

Attachment: simplest possible fix

I have whipped up a patch showing what I think would be the smallest possible fix but it involves repeated code. I think we could do something better and less hacky but it would require some refactoring of the _fillForm() function and thus more regression testing. I haven't even tested the patch yet as I don't currently have a working build environment but I'm happy to take a crack at if desired and with a steer towards minimal change vs. cleaning up code.