952874 - Telemetry collection for RSA/DHE key sizes of 1025-1280 bits is wrong

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: fix-AccumulateNonECCKeySize.patch

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8351075 [details] [diff] [review]
fix-AccumulateNonECCKeySize.patch

Review of attachment 8351075 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

By the way, "accumulate" in AccummulateECCCurve is misspelled - maybe it would be nice to fix that while we're here.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8c1d3f35858

(In reply to David Keeler (:keeler) from comment #2)
> By the way, "accumulate" in AccummulateECCCurve is misspelled - maybe it
> would be nice to fix that while we're here.

Fixed when I checked in the patch.

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8351075 [details] [diff] [review]
fix-AccumulateNonECCKeySize.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 707275
User impact if declined: None, but we'll not have accurate telemetry for certificate public key sizes.
Testing completed (on m-c, etc.): Just landed on m-i.
Risk to taking this patch (and alternatives if risky): Zero risk to end users.
String or IDL/UUID changes made by this patch: None.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d8c1d3f35858

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/29256432e26d
https://hg.mozilla.org/releases/mozilla-beta/rev/022a1f0ec3fd