952887 - [Fugu] B2G DSDS: set 'ro.moz.ril.data_reg_on_demand' for data call to work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Jessica Jong [:jessica] (inactive)]

Need to set 'ro.moz.ril.data_reg_on_demand' to true in some mk file for data call to work.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

1.3? as it blocks 1.3+ bug 948854.

Comment 2

[James Zhang (Spreadtrum)]

Need I add 'ro.moz.ril.data_reg_on_demand' to device makefile in spreadtrum git repo?

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to James Zhang from comment #2)
> Need I add 'ro.moz.ril.data_reg_on_demand' to device makefile in spreadtrum
> git repo?

I am still not sure where this quirk needs to be added after bug 952044. That said, are we still using sprd git repo for device configuration even after bug 952044? If yes, then we need sprd's help for adding this new property. 

I am expecting Thomas's further confirmation as he is the one taking care of bug 952044.

Comment 4

[thomas tsai]

Mozilla only maintains device-fugu. sp7710ga_gonk dependent are maintained by spreadtrum, so ro.moz.ril.data_reg_on_demand is necessary for sp7710ga_gonk. bug 952044 just provides DSDS build environment, so a single sim and DSDS build can be built individually by different commands.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to thomas tsai from comment #4)
> Mozilla only maintains device-fugu. sp7710ga_gonk dependent are maintained
> by spreadtrum, so ro.moz.ril.data_reg_on_demand is necessary for
> sp7710ga_gonk. bug 952044 just provides DSDS build environment, so a single
> sim and DSDS build can be built individually by different commands.

It's clear to me now. Then, would you help add this property on sprd git repo, James?

Comment 6

[James Zhang (Spreadtrum)]

Thomas, can you give me a patch for this bug? ro.moz.ril.data_reg_on_demand = true or false?

Comment 7

[thomas tsai]

device/sprd/sp7710ga_gonk/base.mk:

PRODUCT_PROPERTY_OVERRIDES := \
	ro.moz.omx.hw.max_width=720 \
	ro.moz.omx.hw.max_height=576 \
	ro.moz.ril.query_icc_count=true \
	ro.moz.mute.call.to_ril=true \
        ro.moz.ril.data_reg_on_demand=true

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to thomas tsai from comment #7)
> device/sprd/sp7710ga_gonk/base.mk:
> 
> PRODUCT_PROPERTY_OVERRIDES := \
> 	ro.moz.omx.hw.max_width=720 \
> 	ro.moz.omx.hw.max_height=576 \
> 	ro.moz.ril.query_icc_count=true \
> 	ro.moz.mute.call.to_ril=true \
>         ro.moz.ril.data_reg_on_demand=true

Yeah, this looks good. Please add the new line as Thomas commented. Thanks.

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #8)
> (In reply to thomas tsai from comment #7)
> > device/sprd/sp7710ga_gonk/base.mk:
> > 
> > PRODUCT_PROPERTY_OVERRIDES := \
> > 	ro.moz.omx.hw.max_width=720 \
> > 	ro.moz.omx.hw.max_height=576 \
> > 	ro.moz.ril.query_icc_count=true \
> > 	ro.moz.mute.call.to_ril=true \
> >         ro.moz.ril.data_reg_on_demand=true
> 
> Yeah, this looks good. Please add the new line as Thomas commented. Thanks.

Oh, wait... we should add this to /device/sprd/sp7710gaplus_gonk/base.mk. 
Let us have more tests before getting back to you guys.

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: 0001-Bug-952887-Fugu-B2G-DSDS-set-ro.moz.ril.data_reg_on_.patch

add |ro.moz.ril.data_reg_on_demand=true| to /device/sprd/sp7710gaplus_gonk/base.mk

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #10)
> Created attachment 8351293 [details] [diff] [review]
> 0001-Bug-952887-Fugu-B2G-DSDS-set-ro.moz.ril.data_reg_on_.patch
> 
> add |ro.moz.ril.data_reg_on_demand=true| to
> /device/sprd/sp7710gaplus_gonk/base.mk

Hi Sam and James, 

Please help add this patch to sprd git repo to fix this issue. Thank you.

Comment 12

[sam.hua]

I have pushed it.

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to sam.hua from comment #12)
> I have pushed it.

Thanks, Sam.

We'll close this once we verify the fix being available on repo.

Comment 14

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Verified the property has been added into partner's git repo.

Comment 15

[Jason Smith [:jsmith]]

Sounds like a requirement for DSDS, so blocking+

Comment 16

[Ryan VanderMeulen [:RyanVM]]

IIUC, fixed in a partner repo = POVB = nothing to do on our end