952907 - [Bluetooth] Remove unused event idl

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

Since event generator has supported WebIDL, it's time to remove those event IDLs. :)

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Use WebIDL codegen to implement Bluetooth events

Smaug, could you review the patch? Not sure if the superreview is required for this change and who I should ask for. Please let me know if you have any suggestions. Thanks.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8360286 [details] [diff] [review]
Patch 1(v1): Use WebIDL codegen to implement Bluetooth events


>+    BluetoothDeviceEventInit init;
>+    init.mBubbles = false;
>+    init.mCancelable = false;
>+    init.mDevice = device;
>+    nsRefPtr<BluetoothDeviceEvent> event =
>+      BluetoothDeviceEvent::Constructor(this, NS_LITERAL_STRING("devicefound"), init);
>+    event->SetTrusted(true);
>     DispatchTrustedEvent(event);
DispatchTrustedEvent makes the event trusted, so no need to call 
event->SetTrusted(true);

>+    nsRefPtr<BluetoothStatusChangedEvent> event =
>+      BluetoothStatusChangedEvent::Constructor(this, aData.name(), init);
>+    event->SetTrusted(true);
>     DispatchTrustedEvent(event);
ditto, remove event->SetTrusted(true);


> 
> NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED(BluetoothDevice)
>-  NS_INTERFACE_MAP_ENTRY(nsIDOMBluetoothDevice)
>-  NS_DOM_INTERFACE_MAP_ENTRY_CLASSINFO(BluetoothDevice)
> NS_INTERFACE_MAP_END_INHERITING(nsDOMEventTargetHelper)
So we don't need this stuff here at all anymore.
I think you could remove this and NS_DECL_ISUPPORTS_INHERITED from .h
 
> NS_IMPL_ADDREF_INHERITED(BluetoothDevice, nsDOMEventTargetHelper)
> NS_IMPL_RELEASE_INHERITED(BluetoothDevice, nsDOMEventTargetHelper)
and then also these.

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

Thanks for your comments, smaug.

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1: Use WebIDL codegen to implement Bluetooth events

The patch is refined based on the comments from smaug.

I also removed some macros in BluetoothAdapter.cpp and BluetoothDevice.cpp. However, I'm not quite sure if it's alright. Could you give me a hand, smaug? Please let me know if there's a better candidate. Thanks.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8362482 [details] [diff] [review]
Patch 1: Use WebIDL codegen to implement Bluetooth events

Bah, sorry, the previous patch didn't have context enough to show that
there is special tracing. So the cycle collection stuff can't be removed after all.

Comment 6

[Gina Yeh [:gyeh] [:ginayeh]]

Let me add them back. Thanks.

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: [Final] Patch 1: Use WebIDL codegen to implement Bluetooth events, r=smaug

try:
https://tbpl.mozilla.org/?tree=Try&rev=c905a1424173

Comment 8

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: [Final] Patch 1: Use WebIDL codegen to implement Bluetooth events, r=smaug

try:
https://tbpl.mozilla.org/?tree=Try&rev=21626a481939

Comment 9

[Gina Yeh [:gyeh] [:ginayeh]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7f40e1e33096

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f40e1e33096