952912 - System update check for NOFTU build

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

Currently in bootstrap.js it only enable gaia.system.checkForUpdates when ftu is done. But there may be a chance the phone is booted without FTU.
We should also listen to ftuskip event here.

Comment 1

[Sukant Garg [:gargsms]]

I was not able to check/reproduce this as I am using the latest version already. Should I build a lower version of Gaia (from where?) for this or I can work without that?

Comment 2

[Cédric de Saint Martin]

I can reproduce with latest build. Before any change, where should this be tested?

Comment 3

[Cédric de Saint Martin]

Attachment: Fix bug and test it, v0

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Nice work, I will check tomorrow.

Comment 5

[Cédric de Saint Martin]

I've updated the pull request to fix the isolation of another test that was failing because of my new mocks. During the review, I would like you to pay attention to the way I define/use the mocks in the bootstrap test, I am not sure everything is good there and this is in fact the important part of the commit.

I've also referenced a simple typo bug as dependency.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8373068 [details] [review]
Fix bug and test it, v0

Thanks for adding the unit test for one line patch!

Please rebase and squash your commits.

Comment 7

[Cédric de Saint Martin]

Rebased, squashed.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/f9d91630ad16b44acd46a467d7ebc77aa4276297
Thanks contributor!