two Cocoa objects (one Dictionary, one Array) leaked during startup

RESOLVED FIXED in mozilla29

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

unspecified
mozilla29
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 8351176 [details] [diff] [review]
getsystemversion-autorelease

Observed during launch, since the refactoring of OS X version checks in bug 676907:

objc[12683]: Object 0x1004bc7c0 of class __NSCFDictionary autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug
objc[12683]: Object 0x1004ca7f0 of class __NSArrayM autoreleased with no pool in place - just leaking - break on objc_autoreleaseNoPool() to debug

Patch attached.
Attachment #8351176 - Flags: review?(bgirard)
(Assignee)

Comment 1

4 years ago
Created attachment 8351177 [details] [diff] [review]
Ensure an autorelease pool is in place in InitializeVersionNumbers() before calling Cocoa APIs.

Oops, that needs an extra #include or else it'll break in non-unified builds. Sorry for the churn.
Attachment #8351177 - Flags: review?(bgirard)
(Assignee)

Updated

4 years ago
Attachment #8351176 - Attachment is obsolete: true
Attachment #8351176 - Flags: review?(bgirard)
Comment on attachment 8351177 [details] [diff] [review]
Ensure an autorelease pool is in place in InitializeVersionNumbers() before calling Cocoa APIs.

Thanks!
Attachment #8351177 - Flags: review?(bgirard) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f5ac5ff7d43
Target Milestone: --- → mozilla29
https://hg.mozilla.org/mozilla-central/rev/0f5ac5ff7d43
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.