Compile array comprehensions

RESOLVED FIXED in mozilla31

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla31
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I was just looking at a fuzz bug and noticed we don't Baseline/Ion-compile this expression due to the JSOP_ARRAYPUSH op:

    print([x for (x in a) if (x < 10)]);

This is one of the few remaining ops we don't JIT at all, but it should be pretty easy to slow-path this, at least for Baseline.
(Assignee)

Updated

5 years ago
Depends on: 952944
(Assignee)

Comment 1

4 years ago
Created attachment 8397897 [details] [diff] [review]
Baseline-compile JSOP_ARRAYPUSH

Very simple patch to compile JSOP_ARRAYPUSH.
Attachment #8397897 - Flags: review?(kvijayan)

Updated

4 years ago
Attachment #8397897 - Flags: review?(kvijayan) → review+

Updated

4 years ago
Blocks: 989348
https://hg.mozilla.org/mozilla-central/rev/9e523f572459
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.