Status

()

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla29
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

Posted patch PatchSplinter Review
A bunch of minor changes for bug 952942:

* Emit a JSOP_GETLOCAL right before JSOP_ARRAYPUSH, so that JSOP_ARRAYPUSH can just pop the object from the stack and is a bit simpler to implement.

* Rename js_NewbornArrayPush to js::NewbornArrayPush

* Inline NewbornArrayPushImpl into NewBornArrayPush since it's the only caller
Attachment #8351209 - Flags: review?(jorendorff)
Comment on attachment 8351209 [details] [diff] [review]
Patch

Review of attachment 8351209 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8351209 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/56f89ea332f7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.