If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

There should be adjective instead of nominative used in monthlyDayOfNth

RESOLVED FIXED in 3.2

Status

Calendar
Dialogs
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Hubert Gajewski, Assigned: Decathlon)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

8.71 KB, patch
Fallen
: review+
Details | Diff | Splinter Review
(Reporter)

Description

4 years ago
It is related to Polish version of Lightning but it could NOT be fixed by localizers.

1. Open New event window
2. Go to Repeat dropdown list and select the last option (custom)
3. Go to Repeat dropdown list and select Montly
4. Select "2", "7" and "Last day"
5. Click OK

Result:
Close to Repeat dropdown list there is a sentence with summary. In Polish version of Lightning the sentence is NOT correct: "w 2, 7 i ostatni dzień miesiąca(...)"

Expected:
Close to Repeat dropdown list there is a sentence with summary. In Polish version of Lightning the sentence is correct: "w 2., 7. i ostatni dzień miesiąca(...)"

- there should be a dot after each number (in Polish "2." means "the second", "2" means "two")

There is no way to localize it.
(Assignee)

Comment 1

4 years ago
Created attachment 8351351 [details] [diff] [review]
patch - v1

I can image that some locale might require different strings or symbols for different days of the month, so I've tried to address the issue in this way.
Assignee: nobody → bv1578
Status: NEW → ASSIGNED
Attachment #8351351 - Flags: review?(philipp)
Comment on attachment 8351351 [details] [diff] [review]
patch - v1

Review of attachment 8351351 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp, just a few comments for consideration. You can push without another review if the answer is no.

::: calendar/locales/en-US/chrome/calendar/calendar-event-dialog.properties
@@ +126,5 @@
> +# Allows to insert a string, a character or a symbol after the numbers of a day
> +# in a monthly rule monthlyDayOfNth in order to give to each day number the
> +# meaning of ordinal number (e.g.  1 -> 1st; 2 -> 2nd etc.).
> +# Use a single string if the symbol used is the same for every monthday, otherwise
> +# write a sequence of _31_ string (one for every monthday) separated with commas.

typo: string/strings.

@@ +133,5 @@
> +# monthdayOrdinalSymbol=.
> +#    -> "Occurs day 1., 2., 10. and 11. of every 2 months"
> +# monthdayOrdinalSymbol=st,nd,th,th,th,th,th,th,th,th,th,th,th,th,th,th,th,th,th,th,st,nd,th,th,th,th,th,th,th,th,st
> +#    -> "Occurs day 1st, 2nd, 10th and 11th of every 2 months"
> +monthdayOrdinalSymbol=

Could you use PluralForm.jsm for this somehow?
Attachment #8351351 - Flags: review?(philipp) → review+
Also, for en-US, 3 and 23 should be "rd" as in "third" and "twenty-third".
(In reply to Matthew Mecca [:mmecca] from comment #3)
> Also, for en-US, 3 and 23 should be "rd" as in "third" and "twenty-third".

Nevermind, I missed that it was just part of the localization note.
(Assignee)

Comment 5

4 years ago
Created attachment 8363004 [details] [diff] [review]
patch - v2

(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Could you use PluralForm.jsm for this somehow?

You are right, it needs a plural according to the number of days.
I don't see another way than separating the string monthlyDayOfNth (and hence changing his name) in order to allow a plural for "day" and another for "month". 
So I've created two new strings "monthlyDaysOfNth_day" (for the new plural) and "monthlyDaysOfNth_ordSymbol" (for this bug) and changed the string's name "monthlyDayOfNth" into "monthlyDaysOfNth".

(In reply to Matthew Mecca [:mmecca] from comment #3)
> Also, for en-US, 3 and 23 should be "rd" as in "third" and "twenty-third".

Thanks.
In your opinion, and others as well, should the sentence for the en-US locale sound differently?
At the moment for the en-US there are sentences like these:

"Occurs days 2, 4, 6 and the last day of every 2 months"
"Occurs day 5 of every month"
Attachment #8351351 - Attachment is obsolete: true
Attachment #8363004 - Flags: review?(philipp)
(In reply to Decathlon from comment #5)

> "Occurs days 2, 4, 6 and the last day of every 2 months"
> "Occurs day 5 of every month"
If we are going for the use of st/nd/rd/th, then this would probably be ideal:

"Occurs on the 2nd, 4th, 6th and last day of very 2 months"
"Occurs on the 5th day of every month"
(Assignee)

Comment 7

4 years ago
(In reply to Philipp Kewisch [:Fallen] from comment #6)

> If we are going for the use of st/nd/rd/th, then this would probably be
> ideal:
> 
> "Occurs on the 2nd, 4th, 6th and last day of very 2 months"
> "Occurs on the 5th day of every month"

But should we go with st/nd/rd/th?
If both are as much good I would leave the code as it is (i.e. the proposed patch without st/nd/rd/th).
Comment on attachment 8363004 [details] [diff] [review]
patch - v2

I think both versions are just as good. r=philipp
Attachment #8363004 - Flags: review?(philipp) → review+
(Assignee)

Comment 9

4 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/ffcb78ff2dd5

Fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 3.1
(Assignee)

Updated

4 years ago
Target Milestone: 3.1 → 3.2
You need to log in before you can comment on or make changes to this bug.