953031 - "Communications" app needs an icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

It's being show up in the App Manager as a broken image. We should fix that.

The patch should be as simple as copying the "gear" System app icon to communications app. I don't think the use case deserved it's own icon, for now.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR:

1. Run app manager and start Simulator
https://developer.mozilla.org/en-US/Firefox_OS/Using_the_App_Manager
2. Observe the list of installed apps, identify the "Communications" app

Expected:

1. The app entry comes with an icon.

Actual:

1. The app being showed with a broken image.

Comment 2

[[e-mail]]

I would like to work on this bug

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Assigning.

Please submit a patch to Gaia according to
https://github.com/timdream/gaia#hacking-gaia
specifically,
https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Hacking#Submitting_a_patch

Thanks!

Comment 4

[p0ff]

Since there's no patch yet, can I be assigned this bug?

Comment 5

[p0ff]

Also, the Browser, Built-in Keyboard and System Ringtones icons seem to be missing.  Should I fix them as well?

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Reassigning, sorry for the delay.

(In reply to abhizuko from comment #5)
> Also, the Browser, Built-in Keyboard and System Ringtones icons seem to be
> missing.  Should I fix them as well?

There is another bug about the built-in keyboard. We are waiting for visual team to provide the icon.

There are icons for System ringtone:
https://github.com/mozilla-b2g/gaia/tree/master/apps/setringtone/style/icons

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #6)
> There is another bug about the built-in keyboard. We are waiting for visual
> team to provide the icon.

bug 953032

Comment 8

[p0ff]

I'm having a bit of trouble finding the relevant code to edit...

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to p0ff from comment #8)
> I'm having a bit of trouble finding the relevant code to edit...

The system icons lives here

https://github.com/mozilla-b2g/gaia/tree/master/apps/system/style/icons

This bug is about copy it to somewhere in apps/communication and modify the manifest so that people with App Manager can see an icon when he/she connects the phone.

Comment 10

[p0ff]

Where exactly would I find the manifest?  Also, should I make a directory communications/style/icons and copy thesystem icons there, or should I just link the system icons directly?

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to p0ff from comment #10)
> Where exactly would I find the manifest?  Also, should I make a directory
> communications/style/icons and copy thesystem icons there, or should I just
> link the system icons directly?

You should create a directory, copy and rename the system icon files.

For the manifest, copy and modify the relevant session from apps/system/manifest.webapp to apps/communication/manifest.webapp.

You should figure out how to build your local Gaia to test it out too. You might want to do something like locating the Gaia packages shipped in Simulator and manually replace them with the ones you build.

Comment 12

[p0ff]

https://github.com/mozilla-b2g/gaia/pull/16336

This is the pull request I sent.  I don't think I'll be able to test this presently as I do not have the time.  I'm sorry, but thanks for letting me contribute.

Comment 13

[Benjamin Kerensa [:bkerensa]]

This looks good do we need anything else before merging?

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Benjamin Kerensa [:bkerensa] from comment #13)
> This looks good do we need anything else before merging?

I asked for icon from System app to be copied, not from the Settings app.

Comment 15

[p0ff]

Sorry about that.  I was looking at both and couldn't figure out which icons from system to take since they're different sizes from the rest.

Comment 16

[vijayanand.hongal]

Hi
I can see the gear icons having size of 30 and 45.

But the communications has 60, 90 and 120.png versions.

So is it fine to just add only 30 and 45 sized icons for the communication app ?

Vijayanand

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Since the icon for "Communication" only show up on App Manager, I think it's ok to use the 30/45 sized icons from System app. The same manifest does features some more detailed icons for dialer/contact etc., but they are not related to what we want to fix here.

Comment 18

[vijayanand.hongal]

Attachment: PR

Added the icons and modified the manifest.webapp

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8377580 [details] [review]
PR

Thank you!

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/6e71ab4da1b08586ea0c758edb7aa199ee34cd2f