Closed Bug 953032 Opened 11 years ago Closed 10 years ago

Keyboard app needs an icon

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: timdream, Assigned: ShellHacker, Mentored)

Details

(Whiteboard: [good first bug][mentor-lang=zh][lang=json])

Attachments

(3 files)

mozilla-b2g:master PR#14948
46 bytes, text/x-github-pull-request
rudyl
: review+
Details | Review
_Export_AppPermission_Keyboard.zip
25.27 KB, application/zip
Details
https://github.com/mozilla-b2g/gaia/pull/25117
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review 
The icon will not be displayed anywhere on the phone since it's a certified app, but it will be displayed in App Manager.

It would be good if we could show an icon here. I am copying the icon from System app because such use case doesn't deserve a customized design icon, I think.
Attachment #8351310 - Flags: review?(rlu)
For system we only have 30px icon version, shouldn't that get a 45 entry in manifest as well?
Comment on attachment 8351310 [details] [review]
mozilla-b2g:master PR#14948

Looks good, r=me.
Tim, thanks for wrapping this up.

--
The system app icon mentioned by Jan should be another issue, so giving r+ here.
Attachment #8351310 - Flags: review?(rlu) → review+
(In reply to Jan Jongboom [:janjongboom] from comment #2)
> For system we only have 30px icon version, shouldn't that get a 45 entry in
> manifest as well?

Yes, the icons should have their independent entries on the manifest instead of being replaced by build script.
master: https://github.com/mozilla-b2g/gaia/commit/67a82f88da231969efa4d22df9fb946abf2cf4df
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
The way it's solved now is not nice. The icon is also used for the splash screen on startup, and thus when you go from Settings -> Keyboard -> Built in keyboard. It shows a blown up settings icon. We should have a high res image of a keyboard for that. Before it was just black which was better.
Flags: needinfo?(timdream)
(In reply to Jan Jongboom [:janjongboom] from comment #6)
> The way it's solved now is not nice. The icon is also used for the splash
> screen on startup, and thus when you go from Settings -> Keyboard -> Built
> in keyboard. It shows a blown up settings icon. We should have a high res
> image of a keyboard for that. Before it was just black which was better.

Ouch, I didn't realize that. I guess we need a better icon then? 

master, revert: 27c7bba7991535bfd73172db241e1442d2359162

Patryk, could we get an keyboard app, for the purpose of listing in the App Manager [1] and the launching splash of the Keyboard setting panel? Thanks.

[1] https://developer.mozilla.org/en-US/Firefox_OS/Using_the_App_Manager
Status: RESOLVED → REOPENED
Flags: needinfo?(timdream) → needinfo?(padamczyk)
Resolution: FIXED → ---
Peter, can please provide Tim with the app icon for keyboard, as he states it's purpose is to be displayed in the app manager and in app's setting splash screen. I believe we already have one made for homescreen, so it might be good to unify all these system apps in the process.
Flags: needinfo?(padamczyk) → needinfo?(pla)
Tim is there a deadline, this is for the v.1.4 time frame correct?
Flags: needinfo?(timdream)
There isn't. It's just a nice-to-have polish facing developers.
Flags: needinfo?(timdream)
Assignee: nobody → pla
Flags: needinfo?(pla)
This bug was sit idle for 6 months. Omega, what's your opinion on this? Can Carol provide an icon or I should use the System app icon again?
Assignee: pla → nobody
Status: REOPENED → NEW
Flags: needinfo?(ofeng)
I think Carol can provide an icon for that.
Flags: needinfo?(ofeng) → needinfo?(chuang)
Flags: needinfo?(chuang)
Flags: needinfo?(timdream)
Hi Tim,
Here's the images for Keyboard icon. Thanks!
Woot! Thank you very much.
Mentor: timdream
Flags: needinfo?(timdream)
Whiteboard: [good first bug][mentor-lang=zh][lang=json]
Can I give it a try ?
Sure, why not :)
Assignee: nobody → vaishnav.rd
Status: NEW → ASSIGNED
Flags: needinfo?(vaishnav.rd)
Ram,

Do you know what to do to get the icons into the keyboard app?
Can I work on this ?
Sudheesh,

Sure, assign to you due to inactivity from Ram.
Assignee: vaishnav.rd → sudheesh1995
Flags: needinfo?(vaishnav.rd) → needinfo?(sudheesh1995)
Thanks for the design inputs Carol, these images have been put into the pull request.
Attachment #8504539 - Flags: review?(timdream)
Flags: needinfo?(sudheesh1995)
Thanks Sudheesh for taking this up. I was quite busy with some other work.
No issues Ram :)
Comment on attachment 8504539 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25117

Did you compress the PNG files with ./tools/png_recompress.sh ?
Flags: needinfo?(sudheesh1995)
No Tim, I just thought i'd have to put it up, should i be in the icons folder before running ./tools/png_recompress.sh ?
Flags: needinfo?(sudheesh1995)
Update :

error: optipng not found
(In reply to Sudheesh Singanamalla (:ShellHacker) from comment #24)
> No Tim, I just thought i'd have to put it up, should i be in the icons
> folder before running ./tools/png_recompress.sh ?

Yes, please compress the assets before checking it into the repo. Sorry for not mentioned it beforehand.

(In reply to Sudheesh Singanamalla (:ShellHacker) from comment #25)
> Update :
> 
> error: optipng not found

You need to install optipng on your platform. Which OS you are using currently?
Flags: needinfo?(sudheesh1995)
I am running Mac OS X with Homebrew
I installed the image packages using
brew install advancecomp gifsicle jhead jpegoptim jpeg optipng pngcrush pngquant

and compressed the files, rebased and pushed back to the same pull request.
Flags: needinfo?(sudheesh1995)
master: https://github.com/mozilla-b2g/gaia/commit/7301ddaae46b4977c8fb87f7a6e8d0d112d453aa
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: