Closed Bug 953033 Opened 11 years ago Closed 10 years ago

Add Dzongkha Input Method for B2G

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: chris.fynn, Assigned: me)

Details

Attachments

(1 file)

Patch to Add Dzongkha Input Method for B2G
46 bytes, text/x-github-pull-request
rudyl
: review+
Details | Review 
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131205075310

Steps to reproduce:

Tried to type in Dzongkha (dz_BT). 


Actual results:

No input method found for Dzongkha.


Expected results:

A keyboard supporting Tibean characters and Dzonkkha language should be available.



Note: Dzongkha is the national language of Bhutan and is written in the Tibetan script. 

Also see: Bug 953028
Hello Chris, I gave started to work on it. I will norify you soon regarding that.
Hello Chris, I have started to work on it. I will notify you soon regarding that.
I just created a Pull Request on github by adding patch to add input method for B2G.

But I think the bug #953028 need to be fixed before fixing this bug . I also added patch to fix that bug.
Assign to Rabbi, since he has provided a patch.
Assignee: nobody → me
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8385356 [details] [review]
Patch to Add Dzongkha Input Method for B2G

set review to myself to keep this in my queue.
Will try it out on the device.
Attachment #8385356 - Flags: review?(rlu)
Comment on attachment 8385356 [details] [review]
Patch to Add Dzongkha Input Method for B2G

I just tried this patch on buri, but could not see the font (it would show gray block for each char).

Could you please help make sure the font is ready?

--
BTW, is this new layout should be a default layout for any language?
If yes, please help add it into,
build/config/keyboard-layouts.json.

Thanks.
Attachment #8385356 - Flags: review?(rlu)
Comment on attachment 8385356 [details] [review]
Patch to Add Dzongkha Input Method for B2G

Sorry that I made a mistake to try your patch on a device without that font.

So the patch looks pretty good to me, so giving a r+ here.
Do you think we should find someone in community to review this or you are native in this language?

Thanks.
Attachment #8385356 - Flags: review+
Flags: needinfo?(me)
(In reply to Rudy Lu [:rudyl] from comment #7)
> Comment on attachment 8385356 [details] [review]
> Patch to Add Dzongkha Input Method for B2G
> 
> I just tried this patch on buri, but could not see the font (it would show
> gray block for each char).
> 
> Could you please help make sure the font is ready?
> 
The font is already merged onto the MozTT repo. And you can see the font If you use Firefox OS 1.4+ 
> --
> BTW, is this new layout should be a default layout for any language?
> If yes, please help add it into,
> build/config/keyboard-layouts.json.
No, this layout won't be default in any language.

(In reply to Rudy Lu [:rudyl] from comment #8)
> Comment on attachment 8385356 [details] [review]
> Patch to Add Dzongkha Input Method for B2G
> 
> Sorry that I made a mistake to try your patch on a device without that font.
> 
> So the patch looks pretty good to me, so giving a r+ here.
> Do you think we should find someone in community to review this or you are
> native in this language?
I am not Native in this language. But me &  Christopher J. Fynn (Bug Reported by him) discussed a lot about the keyboard layout. After that he tested it and confirmed me that the keyboard is working properly.
Flags: needinfo?(me)
If you need, you can assign someone to review. @Rudy Lu
Rabbi,

Ok, then I think we're almost done to merge this change.

1. Could you please help provide a native label for this keyboard layout?
https://github.com/mozilla-b2g/gaia/pull/16829/files#r12414596

2. Before merging, we'd better squash your commits into a single commit for better tracking.
   > git rebase -i master
   Let me know if you need help on this.

Thanks.
Flags: needinfo?(me)
(In reply to Rudy Lu [:rudyl] from comment #11)
> Rabbi,
> 
> Ok, then I think we're almost done to merge this change.
> 
> 1. Could you please help provide a native label for this keyboard layout?
> https://github.com/mozilla-b2g/gaia/pull/16829/files#﷒0﷓
> 

Already done it. Please check it.

> 2. Before merging, we'd better squash your commits into a single commit for
> better tracking.
>    > git rebase -i master
>    Let me know if you need help on this.

I can't squash the commit now. Because I don't have the gaia repo in my local PC and My net connection is terribly slow to download this repo. I need your help in this matter.

Thanks
Flags: needinfo?(me)
Squshed and merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/af3fe957dde36ce8272e36900243b5b6c312ef77

Thank you!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Hello Rudy,

Thanks for merging the PR. For the Dzongkha Font's bug, reviewer marked that bug will be fixed on Firefox OS 1.4+. So, on which version we are getting the Keyboard?  is that will be available on latest 2.0 nightly builds?
Flags: needinfo?(rlu)
Yes, should be available on 2.0.


But, please be informed that due to ROM size limitation, not all of the keyboard layouts would be installed during build time.
Please refer to https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/CONFIGURE for more details.

Thanks for your interest in this and great contribution!
Flags: needinfo?(rlu)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: