953050 - [keyboard] Myanmar keyboard basic layout is not rendered correctly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Basic layout of Myanmar keyboard

Keyboard is always displayed in upper case for better UX.
But for Myanmar language which alternative layout is not upper case of basic layout, always display in upper case (alternative layout) could be a bad UX.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Alternative layout of Myanmar keyboard

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Don't always display uppercase for Myanmar keyboard.

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

I guess then this Bug is duplicate of Bug 942651 and for that a more general patch is needed since not only Myanmar keyboard *suffers* from this. :)

Comment 4

[Kai-Zhen Li [:seinlin][:kli]]

Yes, it is a duplicate of Bug 942651.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

In Bug 942651, we only handled Arabic, and we could do the same here for Myanmar.
Please refer to the patch there for details.

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Not to do Uppercase conversion for Myanmar keyboard layout

Hi Rudy, I verify on my phone it does work.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8357679 [details] [review]
Not to do Uppercase conversion for Myanmar keyboard layout

r=me.

Thanks for the quick fix. :)

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/ab92f1dc05d300f3bc9e22a7b9f0f433c5ff5704


Kai-Zhen, thank you!