95310 - res\arrowd.gif does not get installed on Unix

Status: RESOLVED INCOMPLETE

(Core :: Layout: Form Controls, defect)

Description

[Jeff Doozan]

Without res\arrow.gif, there's no down arrow on the dropdown lists within forms.

Comment 1

[cls]

embedding.

Comment 2

[Adam Lock]

Marking NEW. Patch for Win32 is below. Unix probably requires a similar patch

Index: basebrowser-win
===================================================================
RCS file: /cvsroot/mozilla/embedding/config/basebrowser-win,v
retrieving revision 1.30
diff -u -r1.30 basebrowser-win
--- basebrowser-win     2001/08/15 01:25:14     1.30
+++ basebrowser-win     2001/08/15 19:51:47
@@ -263,6 +263,8 @@
 res\viewsource.css
 res\ua.css
 res\forms.css
+res\arrow.gif
+res\arrowd.gif
 res\builtin\buttonBindings.xml
 res\builtin\buttons.css
 res\builtin\checkbox.css

Comment 3

[Adam Lock]

Unix diff. Jeff, do you want to review these changes?

Index: basebrowser-unix
===================================================================
RCS file: /cvsroot/mozilla/embedding/config/basebrowser-unix,v
retrieving revision 1.30
diff -u -r1.30 basebrowser-unix
--- basebrowser-unix    2001/08/09 13:52:29     1.30
+++ basebrowser-unix    2001/08/15 20:17:23
@@ -252,4 +252,5 @@
 res/viewsource.css
 res/ua.css
 res/forms.css
+res/arrow.gif
 res/builtin/*

Comment 4

[Jeff Doozan]

looks good to me.  I'm not sure that arrowd.gif is necessary, but it doesn't
hurt to include it.

r=[e-mail]

Comment 5

[rpotts (gone)]

sr=rpotts.

why does windows get both 'arrow.gif' and 'arrowd.gif' when unix only gets 
'arrow.gif'?

-- rick

Comment 6

[Adam Lock]

My fix is checked in. Reassigning to HTML Form Controls for feedback on the
arrowd.gif issue.

Both res/arrow.gif and res/arrowd.gif are referenced by forms.css but only Win32
has both files. The Unix makefile mozilla/layout/html/document/src/Makefile.in
does not install arrowd.gif at all. Why is this?

http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/forms.css#126
http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/forms.css#135http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/Makefile.in

I have checked in an updated embedding's basebrowser-unix that installs
arrowd.gif but it will generate a warning at the moment because it's not there
to be copied.

Comment 7

[Blake Ross]

arrowd.gif is the "pressed" image of the arrow.  I'm not sure if unix is 
supposed to have it.  (anyways, currently, you don't get that pressed image 
when you mousedown on the arrow in Windows, due to some bug)

Comment 8

[Adam Lock]

*** Bug 96116 has been marked as a duplicate of this bug. ***

Comment 9

[Adam Lock]

Changing summary.

Comment 10

[rods (gone)]

I am not sure this is getting installed anywhere

Comment 11

[Boris Zbarsky [:bzbarsky]]

.