Closed Bug 953314 Opened 6 years ago Closed 6 years ago
Unable to run tinderbox js shells on Windows
Download: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-12-27-mozilla-central-debug/jsshell-win32.zip You will be unable to run it due to a System Error: "The program can't start because icuind50.dll is missing from your computer. Try reinstalling the program to fix this problem." Is it because icuind50.dll is not packaged together in the zip file? Guessing this is probably related to bug 915735. === Tinderbox Build Bisection Results by autoBisect === The "good" changeset has the timestamp "20131206043732", the hash "bbd9375c5f50", and the reason for the result is: Acceptable exit code 3 The "bad" changeset has the timestamp "20131206051028", the hash "099f65a712a8", and the reason for the result is: Negative exit code -1073741515 Likely regression window: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=bbd9375c5f50&tochange=099f65a712a8
Hmm, I thought <http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/packager.mk#105> is supposed to take care of this?
Flags: needinfo?(ehsan) → needinfo?(mh+mozilla)
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #1) > Hmm, I thought > <http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/ > packager.mk#105> is supposed to take care of this? It is.
> Gary, please find a build system hacker who is interested in working on > this. I don't know where to start debugging this. Thanks for looking at this, Ehsan. I'll needinfo our build system overlord. gps, who will be a good person for this? This completely blocks starting up Windows js shells downloaded from tinderbox.
Oh man, this is stupid. XP_WIN isn't defined in Makefiles. I can't believe I didn't notice that in review.
This should work on Windows. I changed the semantics here slightly by taking out the XP_UNIX block, but I don't think it will matter in practice
Attachment #8355517 - Flags: review?(mh+mozilla)
Assignee: nobody → ted
Status: NEW → ASSIGNED
Comment on attachment 8355517 [details] [diff] [review] fix jsshell packaging of ICU libs Review of attachment 8355517 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/mozapps/installer/packager.mk @@ +117,5 @@ > $(DIST)/bin/icuuc$(MOZ_ICU_VERSION).dll \ > $(NULL) > endif # MOZ_DEBUG > else > +ifeq ($(OS_TARGET), Darwin) Fun fact: if you put "else ifeq ($(OS_TARGET), Darwin)" on one line, you only need one endif below.
Thanks for looking at this, Ted!
Attachment #8355517 - Flags: review?(mh+mozilla) → review+
I helped to land this: https://hg.mozilla.org/integration/mozilla-inbound/rev/d1beadca2983
Target Milestone: --- → mozilla29
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.