Closed Bug 953325 Opened 11 years ago Closed 11 years ago

Regression in region.properties (browser, mobile) and searchplugins images

Categories

(Mozilla Localizations :: sq / Albanian, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: flod, Assigned: flod)

References

Details

As part of bug 939834, several changes were made to fix productization aspects

Basic Metro set-up, removed Google Reader from region.properties, updated images (Amazon, Wikipedia) and search URL for Wikipedia, removed en-US searchplugins from mobile, add wikipedia-sq.xml to mobile (bug 616236 and bug 847014).

http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/rev/2e5b98b96489
http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/rev/46efc974ff83
http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/rev/68c9c8613611

Apparently all these changes were reverted in this commit
http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/rev/a8845a53206e

Productization files (region.properties, list.txt, metrolist.txt, XML searchplugins files) are subject to review, so please pay attention when committing such a large number of changes.

Considered the number of changes, I'm going to fix them directly.
Fixed on mozilla-aurora (l10n-central wasn't affected)
http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/rev/ad72c8075f33

@Besnik
Can you explain me how do you work? My guess is that you have a local copy of the repo, unversioned, and you overwrite the content of the repo. 

Can you please make sure you don't overwrite these changes again? Note that I'll probably have to make other changes to searchplugins for Metro.
Assignee: besnik → francesco.lodolo
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(besnik)
Resolution: --- → FIXED
Thank you, Francesco.

I apologize for the mishaps. It all came after hg cloning and overwriting, applied in order to escape commit errors about heads being created during first attempt. I had forgotten to hg update my repo previously, after you fixed and closed some very old bugs about productization.


(In reply to Francesco Lodolo [:flod] from comment #1)
> Fixed on mozilla-aurora (l10n-central wasn't affected)
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/rev/ad72c8075f33
> 
> @Besnik
> Can you explain me how do you work? My guess is that you have a local copy
> of the repo, unversioned, and you overwrite the content of the repo. 
> 
> Can you please make sure you don't overwrite these changes again? 

I'll try...

> I'll probably have to make other changes to searchplugins for Metro.

Many thanks again!
Flags: needinfo?(besnik)
You need to log in before you can comment on or make changes to this bug.