Closed
Bug 953403
Opened 10 years ago
Closed 10 years ago
Open sidebar messes the print preview in compose window
Categories
(Thunderbird :: Message Compose Window, defect)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
48.60 KB,
image/png
|
Details | |
1.85 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
With open sidebar in compose window and entering the print preview messes the window (see screenshot). I also get this error: Sun Dec 29 2013 15:05:50 Error: TypeError: sidebar_title is null Source file: chrome://messenger/content/messengercompose/MsgComposeCommands.js Line: 284 and by closing the print preview I get this error: Sun Dec 29 2013 15:06:39 Warning: ReferenceError: reference to undefined property gChromeState.sidebar Source file: chrome://messenger/content/messengercompose/MsgComposeCommands.js Line: 340
Assignee | ||
Comment 1•10 years ago
|
||
There is no sidebar-title-box and for this entering the preview fails -> removed. Also by quitting the preview SidebarRebuild() doesn't exist -> also removed. Now the preview works also with open sidebar.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8351699 -
Flags: review?(mkmelin+mozilla)
Updated•10 years ago
|
Blocks: 251953
Keywords: regression
Comment 3•10 years ago
|
||
Comment on attachment 8351699 [details] [diff] [review] patch Review of attachment 8351699 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/components/compose/content/MsgComposeCommands.js @@ +342,5 @@ > statusbar.hidden = gChromeState.statusbarWasHidden; > } > > // if we are unhiding and sidebar used to be there rebuild it > + if (!aHide && gChromeState.sidebar == "visible"); huh?
Attachment #8351699 -
Flags: review?(mkmelin+mozilla) → review-
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Magnus Melin from comment #3) > Comment on attachment 8351699 [details] [diff] [review] > patch > > Review of attachment 8351699 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mail/components/compose/content/MsgComposeCommands.js > @@ +342,5 @@ > > statusbar.hidden = gChromeState.statusbarWasHidden; > > } > > > > // if we are unhiding and sidebar used to be there rebuild it > > + if (!aHide && gChromeState.sidebar == "visible"); > > huh? Oops, removed this. Better?
Attachment #8351699 -
Attachment is obsolete: true
Attachment #8355060 -
Flags: review?(mkmelin+mozilla)
Comment 5•10 years ago
|
||
Comment on attachment 8355060 [details] [diff] [review] patch v2 Review of attachment 8355060 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, looks ok! r=mkmelin
Attachment #8355060 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/1e30fba76792
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in
before you can comment on or make changes to this bug.
Description
•