Closed Bug 953492 Opened 10 years ago Closed 10 years ago

access keys enhancement

Categories

(Instantbird Graveyard :: Contacts window, enhancement, P5)

0.1.1
enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

Attachments

(2 files, 3 obsolete files)

*** Original post on bio 41 by Bryce <bryceverdier AT gmail.com> at 2008-02-27 20:05:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***
Attached patch cat'd two patch files to one. (obsolete) — Splinter Review
*** Original post on bio 41 as attmnt 5 by bryceverdier AT gmail.com at 2008-02-27 20:05:00 UTC ***

Here are two patches that include accesskey enhancements(via instantbird.dtd file) to instantbird buddylist for the File, Tools, and ?->About menu entries.
Assignee: florian → bugzilla
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86 → All
Attached patch revision to first patch (obsolete) — Splinter Review
*** Original post on bio 41 as attmnt 6 by bryceverdier AT gmail.com at 2008-02-27 22:02:00 UTC ***

This second patch includes the addition of the commandset & keyset tags so that one can use the full keyboard shortcut of "CTL+A" to access the account setup menu.
Attached patch another revision (obsolete) — Splinter Review
*** Original post on bio 41 as attmnt 7 by bryceverdier AT gmail.com at 2008-02-27 22:37:00 UTC ***

fixed code stylings, as well as fixing the the lack of commandkey in instantbird.dtd from the second patch.
Comment on attachment 8351749 [details] [diff] [review]
cat'd two patch files to one.

*** Original change on bio 41 attmnt 5 by bryceverdier AT gmail.com at 2008-02-27 22:37:21 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351749 - Attachment is obsolete: true
Comment on attachment 8351750 [details] [diff] [review]
revision to first patch

*** Original change on bio 41 attmnt 6 by bryceverdier AT gmail.com at 2008-02-27 22:37:21 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351750 - Attachment is obsolete: true
Attached patch svn diff patchSplinter Review
*** Original post on bio 41 as attmnt 12 by bryceverdier AT gmail.com at 2008-03-03 20:12:00 UTC ***

Here are my code changes from the svn repository ( updated a few minute ago).
Comment on attachment 8351751 [details] [diff] [review]
another revision

*** Original change on bio 41 attmnt 7 by bryceverdier AT gmail.com at 2008-03-03 20:12:47 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351751 - Attachment is obsolete: true
*** Original post on bio 41 at 2008-03-07 21:06:41 UTC ***

Sending        testapp/chrome/content/instantbird/blist.xul
Sending        testapp/chrome/locale/en-US/instantbird/instantbird.dtd
Transmitting file data ..
Committed revision 180.

Fixed, thanks!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.1.2
Attached patch follow up patchSplinter Review
*** Original post on bio 41 as attmnt 27 at 2008-06-22 22:49:00 UTC ***

Apparently the Ctrl+A shortcut doesn't work. With a debug build I get this on stderr:

###!!! ASSERTION: A XUL <key> is observing a command that doesn't exist. Unable to execute key binding!
: 'Error', file /home/florian/build2/svn/instantbird/trunk/mozilla/content/xbl/src/nsXBLWindowKeyHandler.cpp, line 550

Envoi          instantbird/base/content/instantbird/blist.xul
Transmission des donnees .
Revision 215 propagee.
You need to log in before you can comment on or make changes to this bug.