953495 - Crash [@ purple_accounts_delete] when exiting and duplicated accounts exist

Status: RESOLVED FIXED

(Chat Core :: General, defect, P5)

Description

[Florian Quèze [:florian]]

*** Original post on bio 44 at 2008-03-02 13:36:00 UTC ***

*** Due to BzAPI limitations, the initial description is in comment 1 ***

Comment 1

[Florian Quèze [:florian]]

Attachment: Valgrind log

*** Original post on bio 44 as attmnt 10 at 2008-03-02 13:36:00 UTC ***

purpleAccout::create should ensure another account with the same name and protocol doesn't exist before calling purple_account_new.

Pidgin does it:
http://lxr.instantbird.org/pidgin2.2.1/source/pidgin/gtkaccount.c#1191

Valgrind log of the crash attached.

Comment 2

[Florian Quèze [:florian]]

Attachment: patch

*** Original post on bio 44 as attmnt 11 at 2008-03-02 13:39:00 UTC ***

This patch will ensure we don't create duplicate accounts on the libpurple side, and will return an error to the JavaScript caller.

We should also fix this in the UI side and prevent the account wizard from allowing the user to enter a duplicate account.  A warning should be displayed at step 2 and the "next" button should be disabled when the user is about to create a duplicate.

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 44 at 2008-03-07 21:48:08 UTC ***

Sending        xpcom/src/purpleAccount.cpp
Transmitting file data .
Committed revision 183.

Fixed. Filed bug 953497 (bio 46) to take care of the UI issue.