Closed Bug 953532 Opened 10 years ago Closed 10 years ago

[meta] Don't try to autoconnect an account that crashed at the previous connection

Categories

(Chat Core :: General, defect)

0.1.2
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

References

Details

*** Original post on bio 81 at 2008-08-09 19:13:00 UTC ***

Think about the 0.1.2 release on Windows and MSN... :-(
Blocks: 953454
*** Original post on bio 81 at 2008-08-29 00:55:29 UTC ***

So... we can probably add a ref-counted object that would be instantiated by the first auto-connection. Each auto-connection would add a reference.
When the account isn't connecting anymore (connected or connection error), the reference would be removed.

Instantiating the object would add a preference (something.autoLoginPending for example). We need to write it to disk immediately (before actually starting the connecting process.
When the object is destructed (ref-count == 0), we remove the preference. However, we would flush the prefs to disk with a timer, so that a crash following quickly the connection would still be caught.

When starting Instantbird, if this pref exists, then the auto-connect feature will be disabled. We should probably add a message explaining it. We probably want to keep the pref until an account is manually successfully connected or we exit the application without crashing.

We should probably special case the automatic connection of accounts at the end of the account wizard, so that we catch the crash and disable automatic connection of the faulty account only at the next start.

We will want to filter out unexpected exits of the application (ctrl-c, X server crash, power loss, ...).
A solution to do this is to compare the timestamp of the LastCrash (saved by breakpad) with the timestamp of auto-connection (which will be the value of the pref we add for this feature). Of course, we will need to check first that breakpad is enabled.
*** Original post on bio 81 at 2008-08-29 01:18:40 UTC ***

(In reply to comment #1)
> We should probably special case the automatic connection of accounts at the end
> of the account wizard, so that we catch the crash and disable automatic
> connection of the faulty account only at the next start.

Accounts that have autologin activated, are edited and then manually connected may be considered as new (i.e. it's the first connection with these parameters).
*** Original post on bio 81 at 2008-08-29 01:23:36 UTC ***

If we start after a crash, we may want to force a check for updates.
Depends on: 953583
Depends on: 953584
Depends on: 953585
Depends on: 953592
Depends on: 953586
Summary: Don't try to autoconnect an account that crashed at the previous connection → [meta] Don't try to autoconnect an account that crashed at the previous connection
*** Original post on bio 81 at 2009-08-02 22:25:32 UTC ***

This was fixed for 0.1.3, except bug 953585 (bio 138) which is a nice improvement but wasn't required to have the main feature we were tracking here working. Resolving as fixed.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: 0.2a1 → 0.1.3
You need to log in before you can comment on or make changes to this bug.