Closed Bug 953535 Opened 10 years ago Closed 10 years ago

Add Key bindings to zoom in conversation window

Categories

(Instantbird Graveyard :: Conversation, enhancement)

0.1.2
x86
All
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: romain, Assigned: romain)

References

Details

Attachments

(1 file, 3 obsolete files)

*** Original post on bio 84 at 2008-08-09 23:35:00 UTC ***

Add key bindings : Ctrl +, Ctrl - and Ctrl 0 in conversation window.
Ctrl + to zoom in
Ctrl - to zoom out
Ctrl 0 to reset to default size
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch Patch no mouse wheel handling (obsolete) — Splinter Review
*** Original post on bio 84 as attmnt 59 at 2008-08-15 05:52:00 UTC ***

First patch, without Ctrl + Mouse wheel handling.
Coming in a few hours ;)
Assignee: florian → romain
Status: NEW → ASSIGNED
Attached patch full patch (obsolete) — Splinter Review
*** Original post on bio 84 as attmnt 60 at 2008-08-15 16:25:00 UTC ***

Added mouse wheel handling.
Attachment #8351804 - Flags: review?(florian)
Comment on attachment 8351803 [details] [diff] [review]
Patch no mouse wheel handling

*** Original change on bio 84 attmnt 59 at 2008-08-15 16:25:56 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351803 - Attachment is obsolete: true
Attached patch patch V3 (obsolete) — Splinter Review
*** Original post on bio 84 as attmnt 61 at 2008-08-15 18:03:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351805 - Flags: review?
Comment on attachment 8351804 [details] [diff] [review]
full patch

*** Original change on bio 84 attmnt 60 at 2008-08-15 18:03:45 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351804 - Attachment is obsolete: true
Attachment #8351804 - Flags: review?(florian)
Comment on attachment 8351805 [details] [diff] [review]
patch V3

*** Original change on bio 84 attmnt 61 at 2008-08-15 18:41:06 UTC ***

I don't really see in which case even.detail could be null for a mouse wheel event, but let's take this.
r=me
Attachment #8351805 - Flags: review? → review+
Attached patch patch v4Splinter Review
*** Original post on bio 84 as attmnt 62 at 2008-08-15 20:37:00 UTC ***

Hmm... I would prefer with the eventlistener inside the object msgObserver. Sorry, I missed that when reviewing.
Comment on attachment 8351805 [details] [diff] [review]
patch V3

*** Original change on bio 84 attmnt 61 at 2008-08-15 20:37:14 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351805 - Attachment is obsolete: true
*** Original post on bio 84 at 2008-08-15 20:51:22 UTC ***

Envoi          instantbird/base/content/instantbird/conversation.xml
Envoi          instantbird/base/content/instantbird/instantbird.js
Envoi          instantbird/base/content/instantbird/instantbird.xul
Envoi          instantbird/locales/en-US/chrome/instantbird/instantbird.dtd
Transmission des donnees ....
Revision 279 propagee.

Fixed, thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: 0.2 → 0.1.3
Blocks: 953578
You need to log in before you can comment on or make changes to this bug.