Closed
Bug 953541
Opened 10 years ago
Closed 10 years ago
When the error message is displayed on several lines, the buttons aren't well displayed
Categories
(Instantbird Graveyard :: Account manager, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
0.1.3
People
(Reporter: romain, Assigned: romain)
Details
(Whiteboard: [0.1.3-blocking])
Attachments
(1 file, 1 obsolete file)
575 bytes,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 90 at 2008-08-11 01:55:00 UTC *** When the error message on Account Manager window is displayed on several lines (begins at 3 on my screen), the buttons are smaller in height. (probably a min-height CSS property to add on buttons).
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 90 as attmnt 46 at 2008-08-11 03:09:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351790 -
Flags: review?
Assignee | ||
Updated•10 years ago
|
Assignee: florian → romain
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 90 as attmnt 47 at 2008-08-11 03:21:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351791 -
Flags: review?
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8351790 [details] [diff] [review] patch *** Original change on bio 90 attmnt 46 at 2008-08-11 03:21:58 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351790 -
Attachment is obsolete: true
Attachment #8351790 -
Flags: review?
Comment 4•10 years ago
|
||
Comment on attachment 8351791 [details] [diff] [review] V2 *** Original change on bio 90 attmnt 47 at 2008-08-11 03:49:52 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351791 -
Flags: review? → review+
Comment 5•10 years ago
|
||
*** Original post on bio 90 at 2008-08-13 21:49:29 UTC *** Sending instantbird/themes/winstripe/instantbird/accounts.css Transmitting file data . Committed revision 271.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 6•10 years ago
|
||
*** Original post on bio 90 at 2008-08-14 04:13:09 UTC *** Reopening, the buttons are now too big.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 7•10 years ago
|
||
*** Original post on bio 90 at 2008-08-21 12:16:40 UTC *** This looks really bad on mac, which doesn't support well buttons with a non-default size. blocking0.2+ We should either backout the fix of find a better solution.
Comment 8•10 years ago
|
||
*** Original post on bio 90 at 2008-09-22 16:12:04 UTC *** I just changed the min-height value to 2em (this value looks good on Mac). We will need to test this on other OSes as well.
Target Milestone: --- → 0.1.3
Comment 9•10 years ago
|
||
*** Original post on bio 90 at 2008-09-26 15:44:11 UTC *** Ok, this looks good on all 3 supported OSes. Marking as FIXED.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Whiteboard: [0.1.3-blocking]
You need to log in
before you can comment on or make changes to this bug.
Description
•