953541 - When the error message is displayed on several lines, the buttons aren't well displayed

Status: RESOLVED FIXED

(Instantbird Graveyard :: Account manager, defect)

Description

[Romain BEZUT]

*** Original post on bio 90 at 2008-08-11 01:55:00 UTC ***

When the error message on Account Manager window is displayed on several lines (begins at 3 on my screen), the buttons are smaller in height.

(probably a min-height CSS property to add on buttons).

Comment 1

[Romain BEZUT]

Attachment: patch

*** Original post on bio 90 as attmnt 46 at 2008-08-11 03:09:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 2

[Romain BEZUT]

Attachment: V2

*** Original post on bio 90 as attmnt 47 at 2008-08-11 03:21:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[Romain BEZUT]

Comment on attachment 8351790 [details] [diff] [review]
patch

*** Original change on bio 90 attmnt 46 at 2008-08-11 03:21:58 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8351791 [details] [diff] [review]
V2

*** Original change on bio 90 attmnt 47 at 2008-08-11 03:49:52 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 5

[Florian Quèze [:florian]]

*** Original post on bio 90 at 2008-08-13 21:49:29 UTC ***

Sending        instantbird/themes/winstripe/instantbird/accounts.css
Transmitting file data .
Committed revision 271.

Comment 6

[Florian Quèze [:florian]]

*** Original post on bio 90 at 2008-08-14 04:13:09 UTC ***

Reopening, the buttons are now too big.

Comment 7

[Florian Quèze [:florian]]

*** Original post on bio 90 at 2008-08-21 12:16:40 UTC ***

This looks really bad on mac, which doesn't support well buttons with a non-default size.

blocking0.2+
We should either backout the fix of find a better solution.

Comment 8

[Florian Quèze [:florian]]

*** Original post on bio 90 at 2008-09-22 16:12:04 UTC ***

I just changed the min-height value to 2em (this value looks good on Mac). We will need to test this on other OSes as well.

Comment 9

[Florian Quèze [:florian]]

*** Original post on bio 90 at 2008-09-26 15:44:11 UTC ***

Ok, this looks good on all 3 supported OSes.  Marking as FIXED.