Closed Bug 953546 Opened 10 years ago Closed 10 years ago

Update progress window not displayed

Categories

(Instantbird Graveyard :: Other, defect)

0.1.2
x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

Details

(Whiteboard: [0.2-blocking])

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 95 at 2008-08-11 22:37:00 UTC ***

I think we forgot to package an update.ini file in the application folder...
*** Original post on bio 95 at 2008-08-21 12:13:33 UTC ***

Now that we upgraded to Mozilla 1.9.1a2pre, we have this error in the Error Console:
Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIINIParserFactory.createINIParser]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///.../InstantbirdDebug.app/Contents/MacOS/components/nsUpdateService.js :: getLocale :: line 513"  data: no]
Source File: file:///.../InstantbirdDebug.app/Contents/MacOS/components/nsUpdateService.js
Line: 513

The code around line 513 is:
/**
 * Gets the locale specified by the 'Locale' key in the 'Installation' section
 * of updater.ini.
 */
function getLocale() {
  if (gLocale)
    return gLocale;

  var updaterIni = getFile(KEY_APPDIR, [FILE_UPDATER_INI]);
  var iniParser = Components.classes["@mozilla.org/xpcom/ini-parser-factory;1"]
                            .getService(nsIINIParserFactory).createINIParser(updaterIni);


So this error seems to be related to the lack of the file updater.ini too.
Attached patch fix (obsolete) — Splinter Review
*** Original post on bio 95 as attmnt 71 at 2008-08-21 12:31:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Status: NEW → ASSIGNED
*** Original post on bio 95 at 2008-08-21 13:14:43 UTC ***

The JS error appeared after the changes from this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=446527
Attached patch better fixSplinter Review
*** Original post on bio 95 as attmnt 72 at 2008-08-21 13:15:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Comment on attachment 8351815 [details] [diff] [review]
fix

*** Original change on bio 95 attmnt 71 at 2008-08-21 13:15:19 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351815 - Attachment is obsolete: true
*** Original post on bio 95 at 2008-08-21 13:18:13 UTC ***

Pushed as 270:b93887646ffd.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Summary: Update progress windows not displayed → Update progress window not displayed
Target Milestone: 0.2 → 0.1.3
Whiteboard: [0.2-blocking]
You need to log in before you can comment on or make changes to this bug.