Closed
Bug 953571
Opened 10 years ago
Closed 10 years ago
When deleting an account, the "Ok" button should be "Delete" instead
Categories
(Instantbird Graveyard :: Account manager, defect)
Instantbird Graveyard
Account manager
Tracking
(Not tracked)
RESOLVED
FIXED
0.1.3
People
(Reporter: romain, Assigned: romain)
Details
Attachments
(1 file, 1 obsolete file)
1.72 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 124 at 2008-09-25 00:42:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 124 as attmnt 100 at 2008-09-25 00:42:00 UTC *** Because the users commonly click on "Yes" or "Ok" without reading the message, it would be better to have a button labeled as "Delete" instead of "Ok". It is already like that in many softwares. ------------- On this patch I use ConfirmEx instead of confirmCheck, it should be like that anywhere where it is possible to prevent a mistake from the user.
Attachment #8351844 -
Flags: review?
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → romain
Status: ASSIGNED → NEW
Comment 2•10 years ago
|
||
Comment on attachment 8351844 [details] [diff] [review] patch *** Original change on bio 124 attmnt 100 at 2008-09-25 08:40:42 UTC *** >diff -r 43b3e5cd830d instantbird/base/content/instantbird/account.xml >--- a/instantbird/base/content/instantbird/account.xml Wed Sep 24 23:46:34 2008 +0200 >+++ b/instantbird/base/content/instantbird/account.xml Thu Sep 25 02:36:41 2008 +0200 >@@ -194,10 +194,13 @@ > var promptTitle = bundle.getString("account.deletePrompt.title"); > var promptMessage = bundle.getString("account.deletePrompt.message"); > var promptCheckbox = bundle.getString("account.deletePrompt.checkbox"); >+ var deleteButton = bundle.getString("account.deleteButton"); Why not account.deletePrompt.button, to be consistent with the previous 3 strings? > > var checkbox = {}; >- if (!prompts.confirmCheck(window, promptTitle, promptMessage, >- promptCheckbox, checkbox)) >+ var flags = prompts.BUTTON_TITLE_IS_STRING * prompts.BUTTON_POS_0 + >+ prompts.BUTTON_TITLE_CANCEL * prompts.BUTTON_POS_1; >+ if (prompts.confirmEx(window, promptTitle, promptMessage, flags, >+ deleteButton, null, null, promptCheckbox, checkbox) != 0) > return; Any reason why you need the != 0 here?
Attachment #8351844 -
Flags: review? → review-
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 124 as attmnt 101 at 2008-09-25 10:38:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351845 -
Flags: review?
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8351844 [details] [diff] [review] patch *** Original change on bio 124 attmnt 100 at 2008-09-25 10:38:42 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351844 -
Attachment is obsolete: true
Comment 5•10 years ago
|
||
Comment on attachment 8351845 [details] [diff] [review] Patch V2 *** Original change on bio 124 attmnt 101 at 2008-09-25 11:08:26 UTC *** r=me. Pushed as 356:ab5921554baa.
Attachment #8351845 -
Flags: review? → review+
Comment 6•10 years ago
|
||
*** Original change on bio 124 at 2008-09-25 11:09:44 UTC was without comment, so any subsequent comment numbers will be shifted ***
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•