Closed Bug 953576 Opened 10 years ago Closed 10 years ago

Separate the css rules of the conversation binding and the conversation window.

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: romain)

Details

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 130 at 2008-09-27 15:25:00 UTC ***

Currently both conversation.xml and instantbird.xul include the same CSS file (instantbird.css) and lots of rules are applied twice...
*** Original post on bio 130 as attmnt 107 at 2008-09-28 02:13:00 UTC ***

Separated both, and tested for each property if it is not executed twice (if I can move it to the new file without breaking anything) (!).

But I am not sure that's was you want.
Attachment #8351851 - Flags: review?
Assignee: nobody → romain
Status: NEW → ASSIGNED
*** Original post on bio 130 at 2008-09-28 09:54:05 UTC ***

Comment on attachment 8351851 [details] [diff] [review] (bio-attmnt 107)
separate convtab and conversation's css

>diff -r 76b739e38df9 instantbird/themes/winstripe/instantbird/conversation.css

>+conversation {
>+%ifdef XP_MACOSX
>+  margin-top: 8px;
>+%else
>+  margin: -1px -1px;
>+%endif
>+  padding: 0 0;
>+}

These rules should stay in the other file. They are for the position of conversations relative to the tabbox.

>+conversation listbox .listcell-label {
>+  font-weight: bold;
>+}
>+
>+conversation listbox .listcell-icon {
>+  min-width: 16px;
>+  -moz-margin-end: 0px;
>+}

Please replace 'conversation listbox' by '.conv-nicklist' here.


>+conversation:not([chat="true"]) .conv-chat {
>+  display: none;
>+}

I'm a bit annoyed by this rule for 2 reasons:
 - It should be in content/, not in themes/, but we would have to create a new file with only 3 lines to do it :-(
 - It should not use 'conversation' in the selector, as the binding can be used with an element of a different local name (even if I've just seen while reviewing your patch for bug 953574 (bio 128) that the current binding depends on the localname being 'conversation' :-().

Let's not block the resolution of this bug for that, but I think we should file another bug to keep it in mind.


>diff -r 76b739e38df9 instantbird/themes/winstripe/instantbird/jar.mn
>--- a/instantbird/themes/winstripe/instantbird/jar.mn	Sat Sep 27 23:54:33 2008 +0200
>+++ b/instantbird/themes/winstripe/instantbird/jar.mn	Sun Sep 28 04:09:23 2008 +0200
>@@ -12,6 +12,7 @@ classic.jar:
> 	skin/winstripe/instantbird/voice.png
> 	skin/winstripe/instantbird/blist.css
> 	skin/winstripe/instantbird/conv.css
>+*	skin/winstripe/instantbird/conversation.css
> *	skin/winstripe/instantbird/instantbird.css

Do we still use the preprocessor in instantbird.css?
Attached patch patchSplinter Review
*** Original post on bio 130 as attmnt 108 at 2008-09-28 12:52:00 UTC ***

Added the preprocessor conditions, and fixed the things you have said ahead.
Attachment #8351852 - Flags: review?
Comment on attachment 8351851 [details] [diff] [review]
separate convtab and conversation's css

*** Original change on bio 130 attmnt 107 at 2008-09-28 12:52:53 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351851 - Attachment is obsolete: true
Attachment #8351851 - Flags: review?
Comment on attachment 8351852 [details] [diff] [review]
patch

*** Original change on bio 130 attmnt 108 at 2008-09-28 22:22:37 UTC ***

Pushed as 371:c6b513e1ff37.

Thanks!
Attachment #8351852 - Flags: review? → review+
*** Original change on bio 130 at 2008-09-28 22:23:35 UTC was without comment, so any subsequent comment numbers will be shifted ***
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.1.3
You need to log in before you can comment on or make changes to this bug.