953584 - Disable autoLogin if Instantbird last run crashed while connecting

Status: RESOLVED FIXED

(Chat Core :: General, enhancement)

Description

[Romain BEZUT]

*** Original post on bio 137 at 2008-10-02 17:25:00 UTC ***

From bug 953532 (bio 81):

"So... we can probably add a ref-counted object that would be instantiated by
the first auto-connection. Each auto-connection would add a reference.
When the account isn't connecting anymore (connected or connection error), the
reference would be removed.

Instantiating the object would add a preference (something.autoLoginPending for
example). We need to write it to disk immediately (before actually starting the
connecting process.
When the object is destructed (ref-count == 0), we remove the preference.
However, we would flush the prefs to disk with a timer, so that a crash
following quickly the connection would still be caught.

When starting Instantbird, if this pref exists, then the auto-connect feature
will be disabled. We should probably add a message explaining it. We probably
want to keep the pref until an account is manually successfully connected or we
exit the application without crashing."

The message explaining this should be in a notification bar on the account manager window.

The pref should be removed when the first account with autoLogin option is connected successfully.

Comment 1

[Romain BEZUT]

*** Original post on bio 137 at 2008-10-02 17:59:07 UTC ***

Moreover, we should check for updates when the application crashed and autoLogin disabled.

Comment 2

[Romain BEZUT]

*** Original post on bio 137 at 2008-10-07 22:36:57 UTC ***

> The message explaining this should be in a notification bar on the account
> manager window.
This is now in Bug 953592 (bio 145)

Comment 3

[Florian Quèze [:florian]]

*** Original post on bio 137 at 2008-11-06 02:34:35 UTC ***

Fixed by the changesets 441:d2ec0e01124b and 443:546bf6e6c112.

(In reply to comment #1)
> Moreover, we should check for updates when the application crashed and
> autoLogin disabled.
> 

We can handle that in another bug.

Comment 4

[Florian Quèze [:florian]]

*** Original change on bio 137 at 2008-11-06 02:34:47 UTC was without comment, so any subsequent comment numbers will be shifted ***