953610 - Do not flash forever on new incoming messages

Status: RESOLVED WORKSFORME

(Instantbird Graveyard :: Conversation, enhancement)

Description

[Florian Quèze [:florian]]

*** Original post on bio 163 at 2009-01-13 12:33:00 UTC ***

When a new message arrives and the conversation window is not focused, we call window.getAttention() on the conversation window.

On Windows, this has for effect of making the taskbar entry and the title bar of the window flash forever, which is visually very distracting. It should flash a few times (3 sounds a sensible number, but it's probably better to make this a pref), and after it should stop flashing but the taskbar entry should stay highlighted.

It's pretty easy limit the number of flashes (just call getAttentionWithCycleCount instead of getAttention).

Note to self: the name getAttentionWithCycleCount is misleading, the count parameter actually counts the number of state change, not the number of flash cycles (probably a bug).

Comment 1

[Benedikt Pfeifer]

*** Original post on bio 163 at 2010-03-03 21:40:04 UTC ***

This works for me. I think it this ( https://bugzilla.mozilla.org/show_bug.cgi?id=313403 ) was the respective bug on Mozilla Bugzilla , fixed with http://hg.mozilla.org/mozilla-central/rev/e783d41a4e4a .

Comment 2

[Florian Quèze [:florian]]

*** Original post on bio 163 at 2010-03-03 22:08:39 UTC ***

(In reply to comment #1)
> This works for me. I think it this (
> https://bugzilla.mozilla.org/show_bug.cgi?id=313403 ) was the respective bug on
> Mozilla Bugzilla , fixed with
> http://hg.mozilla.org/mozilla-central/rev/e783d41a4e4a .

This looks exactly like it, thanks! :)
Resolving as WORKSFORME.