Closed Bug 953619 Opened 10 years ago Closed 10 years ago

Improve "topic notification bar"

Categories

(Instantbird Graveyard :: Conversation, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benediktp, Assigned: benediktp)

Details

Attachments

(2 files, 5 obsolete files)

*** Original post on bio 172 at 2009-04-20 18:27:00 UTC ***

Change the behaviour of the "topic notification bar" to include the following:

Double-click changes the notification bar with the label into a bar with an input element that contains the current topic. Changing this topic and pressing ENTER/changing focus should accept it and set it as new topic of the channel. 

This behaviour could be disabled if the user has insufficient rights on the channel.
Attached image A mockup..
*** Original post on bio 172 as attmnt 136 at 2009-04-20 20:00:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
*** Original post on bio 172 as attmnt 176 at 2009-08-07 20:59:00 UTC ***

I haven't enforced the 80 characters/line max limit, as I don't think it would increase the readability in this case (would lead to strange line breaks instead).
Hopefully my patch meets the requirements.
Attached file New version of the bindings (obsolete) —
*** Original post on bio 172 as attmnt 178 at 2009-08-08 23:32:00 UTC ***

I haven't only changed the coding style as requested, but also removed a bunch of useless if's.
Attached patch Full patch (obsolete) — Splinter Review
*** Original post on bio 172 as attmnt 179 at 2009-08-09 01:45:00 UTC ***

- Fixing the new line in jar.mn
- adding a focus on the textbox when it appears.
- Adding an accesskey on the Change button
- deleting the description before the textbox (as we agreed on IRC).
- I also added a CSS rule to hide the containing elements in so that it does not break the selectedIndex and displays the notification to fit its visible content only.

As a result the height of that bar can change when you double click on it.

I have nearly not changed anything from the original files, so I put r+, assuming that we already discussed all that stuff on IRC and with Florian.

Thanks !
Attachment #8351923 - Flags: review+
Comment on attachment 8351920 [details] [diff] [review]
Proposed solution to this bug, will add an textbox to the bar on dblclick

*** Original change on bio 172 attmnt 176 at 2009-08-09 01:45:15 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351920 - Attachment is obsolete: true
Comment on attachment 8351922 [details]
New version of the bindings

*** Original change on bio 172 attmnt 178 at 2009-08-09 01:45:15 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351922 - Attachment is obsolete: true
Assignee: nobody → benediktp
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Hardware: x86 → All
Target Milestone: --- → 0.2b1
Attached patch Real Full patch (obsolete) — Splinter Review
*** Original post on bio 172 as attmnt 180 at 2009-08-09 01:49:00 UTC ***

Well ... I missed the right file :(
Sorry
Attachment #8351924 - Flags: review+
Comment on attachment 8351923 [details] [diff] [review]
Full patch

*** Original change on bio 172 attmnt 179 at 2009-08-09 01:49:47 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351923 - Attachment is obsolete: true
*** Original post on bio 172 at 2009-08-09 18:14:59 UTC ***

As it is now, there is a focus issue after going to edit the topic (doesn't matter if you accept or cancel the changes).

It can be fixed by adding 

document.getBindingParent(this).focus();

at the end of both the setTopic and cancelEdit methods. I'd have done it myself, but my Windows-diffs from uncompressed jars doesn't seem to be the taste of everyone ;)
Attached patch Real Full patch V2 (obsolete) — Splinter Review
*** Original post on bio 172 as attmnt 181 at 2009-08-09 20:33:00 UTC ***

Minor fix to set the focus back to the conversation once the Topic is changed or canceled.

Thanks again
Attachment #8351925 - Flags: review+
Comment on attachment 8351924 [details] [diff] [review]
Real Full patch

*** Original change on bio 172 attmnt 180 at 2009-08-09 20:33:28 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351924 - Attachment is obsolete: true
*** Original post on bio 172 as attmnt 182 at 2009-08-10 12:10:00 UTC ***

Slightly lighter than the previous (factorizing some pieces of code).
Attachment #8351926 - Flags: review?(florian)
Comment on attachment 8351925 [details] [diff] [review]
Real Full patch V2

*** Original change on bio 172 attmnt 181 at 2009-08-10 12:10:31 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351925 - Attachment is obsolete: true
*** Original post on bio 172 at 2009-08-11 02:02:04 UTC ***

I pushed attachment 8351926 [details] [diff] [review] (bio-attmnt 182) as https://hg.instantbird.org/instantbird/rev/559d82f3468b with 2 minor changes we discussed on IRC:
* Change the copyright year from 2007 to 2009
* Make the double click action to edit also work on the icon on the left of the notification.

Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8351926 [details] [diff] [review]
Full patch, coding style fixes

*** Original change on bio 172 attmnt 182 at 2009-08-20 20:06:57 UTC ***

Adding my review here, but Romain actually did the real review work before on the previous attachments which were improvements of Mic's original patch!
Attachment #8351926 - Flags: review?(florian) → review+
You need to log in before you can comment on or make changes to this bug.