Closed
Bug 953662
Opened 10 years ago
Closed 10 years ago
Edit field including the count of chat room participants is not properly associated with its label
Categories
(Instantbird Graveyard :: Conversation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
0.2b1
People
(Reporter: bugzilla, Assigned: romain)
Details
(Whiteboard: accessibility)
Attachments
(1 file, 2 obsolete files)
2.34 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 216 by Peter Vagner <pvdeejay AT gmail.com> at 2009-08-14 19:44:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Reporter | ||
Comment 1•10 years ago
|
||
*** Original post on bio 216 as attmnt 193 by pvdeejay AT gmail.com at 2009-08-14 19:44:00 UTC *** Steps to reproduce: 1) start IB, 2) Join a chat room, 3) Navigate to the read-only edit field displaying the participant count for the chatroom. 4) Inspect its name using accprobe or use your screen reader to read it. Actual results: The name is blank Expected result: Name of the given edit field should return a text of the label preceeding it. Note: The read-only edit field should get an id and this id should be referenced in the control property of the label.
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8351937 [details] [diff] [review] changes to a file conversation.xml *** Original change on bio 216 attmnt 193 at 2009-08-14 20:16:57 UTC *** Unfortunately this patch won't work because it uses an id in a XBL Binding. There is no other way to use the "control" attribute so we have two possibilities: - Create unique ids based on the tab number or conversationID - Find another way to give a name to this textbox
Attachment #8351937 -
Attachment is patch: true
Attachment #8351937 -
Attachment mime type: application/octet-stream → text/plain
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 216 as attmnt 201 at 2009-08-18 19:49:00 UTC *** If the conversation if a chat, this patch adds an id on the textbox, and a control attribute on the label, base on the timestamp (in milliseconds). This is the way Firefox handle similar things when there is no obvious unique id.
Attachment #8351945 -
Flags: review?(florian)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8351937 [details] [diff] [review] changes to a file conversation.xml *** Original change on bio 216 attmnt 193 at 2009-08-18 19:49:47 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351937 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → romain
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Whiteboard: accessibility
Reporter | ||
Comment 5•10 years ago
|
||
*** Original post on bio 216 by Peter Vagner <pvdeejay AT gmail.com> at 2009-08-19 06:25:58 UTC *** great, I can confirm it really works fine now. Tested with several chatrooms open.
Comment 6•10 years ago
|
||
Comment on attachment 8351945 [details] [diff] [review] Proposed patch *** Original change on bio 216 attmnt 201 at 2009-08-21 10:06:03 UTC *** >diff --git a/instantbird/base/content/instantbird/conversation.xml b/instantbird/base/content/instantbird/conversation.xml > this.addBuddy(n); >+ let timestamp = new Date().getTime(); >+ // Set an ID on the participant count for accessibility reasons >+ document.getAnonymousElementByAttribute(this, "anonid", "participantLabel") >+ .setAttribute("control", "pc" + timestamp.toString()); >+ document.getAnonymousElementByAttribute(this, "anonid", "participantCount") >+ .setAttribute("id", "pc" + timestamp.toString()); > this.updateParticipantCount(); * Why is "pc" + timestamp.toString() duplicated? * The comment should be the first line of the code you are adding. * Maybe add an empty line before and after the code you add for accessibility reasons so that a ready can easily know which lines the comment applies to?
Attachment #8351945 -
Flags: review?(florian) → review-
Assignee | ||
Comment 7•10 years ago
|
||
*** Original post on bio 216 as attmnt 206 at 2009-08-21 10:19:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351950 -
Flags: review?(florian)
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8351945 [details] [diff] [review] Proposed patch *** Original change on bio 216 attmnt 201 at 2009-08-21 10:19:18 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351945 -
Attachment is obsolete: true
Comment 9•10 years ago
|
||
Comment on attachment 8351950 [details] [diff] [review] patch V2 *** Original change on bio 216 attmnt 206 at 2009-08-21 21:43:07 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351950 -
Flags: review?(florian) → review+
Comment 10•10 years ago
|
||
*** Original post on bio 216 at 2009-08-21 21:47:45 UTC *** I pushed this as https://hg.instantbird.org/instantbird/rev/1e09ce7ab655 with some minor modifications.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.2b1
You need to log in
before you can comment on or make changes to this bug.
Description
•