Closed Bug 953666 Opened 10 years ago Closed 10 years ago

Account manager without account should not be just an empty white rectangle

Categories

(Instantbird Graveyard :: Account manager, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: florian, Assigned: romain)

References

Details

Attachments

(1 file, 3 obsolete files)

*** Original post on bio 220 at 2009-08-21 20:19:00 UTC ***

Maybe when the list of accounts is empty, we should display instead a short helpful text to indicate that the user has to add an account?
Blocks: 953623
Attached patch Patch V1 (obsolete) — Splinter Review
*** Original post on bio 220 as attmnt 216 at 2009-08-26 01:21:00 UTC ***

You will wonder why:
> +         <description id="noAccountText">&accountManager.noAccount.description;</description>
And not simply value="[...]"
The answer is about wrapping, with value="", the content is assumed as white-space:pre, so it never breaks on a new line, and in our case it would add a nice scrollbar :).

using the following icon:
chrome://global/skin/icons/information-64.png

"visibility: collapse"
because if we hide the richlist box with display:none, the created account won't be bind until the CSS property (display: none) changes (and we can't guess when it happens).
Attachment #8351960 - Flags: review?(florian)
Assignee: nobody → romain
Status: NEW → ASSIGNED
*** Original post on bio 220 at 2009-08-26 09:46:12 UTC ***

Comment on attachment 8351960 [details] [diff] [review] (bio-attmnt 216)
Patch V1

I haven't done a thorough review yet, but just a quick question:
Have you considered using a <deck> element?

https://developer.mozilla.org/en/XUL/deck
Attached patch Patch using deck (obsolete) — Splinter Review
*** Original post on bio 220 as attmnt 217 at 2009-08-26 10:30:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351961 - Flags: review?(florian)
Comment on attachment 8351960 [details] [diff] [review]
Patch V1

*** Original change on bio 220 attmnt 216 at 2009-08-26 10:30:42 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351960 - Attachment is obsolete: true
Attachment #8351960 - Flags: review?(florian)
*** Original post on bio 220 at 2009-08-26 11:27:30 UTC ***

Comment on attachment 8351961 [details] [diff] [review] (bio-attmnt 217)
Patch using deck

Copying here a few comments I already gave by IM:

1. I love it! :)
2. .selectedIndex = count ? 1 : 0 is ugly.
3. I think we can improve the wording of the message. Maybe we should focus more on telling the user what to do rather than what the state of the application is.
4. I think a double click on that 'screen' should open the new account wizard, like it does when clicking on an empty area of the account list.
Attached patch Patch V3 (obsolete) — Splinter Review
*** Original post on bio 220 as attmnt 218 at 2009-08-26 12:12:00 UTC ***

Fixed as we discussed on IM (see on the comment ahead).
Attachment #8351962 - Flags: review?(florian)
Comment on attachment 8351961 [details] [diff] [review]
Patch using deck

*** Original change on bio 220 attmnt 217 at 2009-08-26 12:12:22 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351961 - Attachment is obsolete: true
Attachment #8351961 - Flags: review?(florian)
Attached patch Patch V4Splinter Review
*** Original post on bio 220 as attmnt 219 at 2009-08-26 13:31:00 UTC ***

Coding style.
Attachment #8351963 - Flags: review?(florian)
Comment on attachment 8351962 [details] [diff] [review]
Patch V3

*** Original change on bio 220 attmnt 218 at 2009-08-26 13:31:28 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351962 - Attachment is obsolete: true
Attachment #8351962 - Flags: review?(florian)
Comment on attachment 8351963 [details] [diff] [review]
Patch V4

*** Original change on bio 220 attmnt 219 at 2009-08-26 13:36:16 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8351963 - Flags: review?(florian) → review+
*** Original post on bio 220 at 2009-08-26 23:07:17 UTC ***

Pushed as:
https://hg.instantbird.org/instantbird/rev/cb2b000ab13c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.2b1
You need to log in before you can comment on or make changes to this bug.