Closed Bug 953673 Opened 10 years ago Closed 10 years ago

Old smiley themes with new smiley script lock application

Categories

(Instantbird Graveyard :: Other, defect)

x86
Windows XP
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benediktp, Assigned: florian)

References

Details

Attachments

(1 file)

*** Original post on bio 227 at 2009-08-28 20:09:00 UTC ***

Having an old smilie theme ('texts' property in theme.js file) installed and the new script that expects 'textCodes' instead will lock the application unusable with a not responding script (imSmileys.jsm), 100% CPU load and increasing memory consumption. It occurs as soon as you receive a message. 

Maybe it's possible to manually change the smilie theme to default or none to work around this temporarily.
Attached patch FixSplinter Review
*** Original post on bio 227 as attmnt 227 at 2009-08-28 21:31:00 UTC ***

The actual problem is that no smiley text is found at all in the theme, so the regexp used for matching smilies inside the conversation ends up being "()".
This patch will disable smiley matching when encountering such a bogus theme.

Additionally, the patch also prevents another case in which bogus themes could lead to create a regexp matching the empty string.

Matching the empty string means that the match doesn't make us advance in the string, so matching goes on forever... and it explains the freeze.

Thanks for reporting that!
Assignee: nobody → florian
Status: NEW → ASSIGNED
*** Original post on bio 227 at 2009-08-29 01:55:54 UTC ***

http://hg.instantbird.org/instantbird/rev/e5aa0d9455ba
Blocks: 953659
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.2b1
You need to log in before you can comment on or make changes to this bug.