Stop logging of existing chats when option becomes set to "do not log"

NEW
Unassigned

Status

--
minor
5 years ago
5 years ago

People

(Reporter: Mic, Unassigned)

Tracking

trunk
x86
Other

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
*** Original post on bio 277 at 2009-12-06 19:25:00 UTC ***

Apparantly logging of existing chats is not stopped when the option is set from "Log chats" to "Do not chats". People might be expecting it to apply immediately.
(Reporter)

Updated

5 years ago
Blocks: 953719
Whiteboard: [0.2-wanted]
(Reporter)

Comment 1

5 years ago
*** Original post on bio 277 at 2010-02-15 12:52:14 UTC ***

Addition: add a message in conversations that tells that logging has been enabled/disabled.
Whiteboard: [0.2-wanted]
(Reporter)

Comment 2

5 years ago
*** Original post on bio 277 at 2010-10-25 21:44:14 UTC ***

Update: the problem is still the same, even with the new javascript logger.
*** Original post on bio 277 at 2010-10-25 21:57:46 UTC ***

(In reply to comment #2)
> Update: the problem is still the same, even with the new javascript logger.

But is probably trivial to "fix" now :).
I'm not really sure of the "good" behavior. Wouldn't it suck if it becomes possible to lose some messages from the log by just looking around in the preferences dialog, and checking/unchecking checkboxes without really thinking about it (or while still reading the label), and assume that you did nothing because you reverted the settings to the way they were before?
(Reporter)

Comment 4

5 years ago
*** Original post on bio 277 at 2011-09-02 10:07:19 UTC ***

(In reply to comment #3)
> (In reply to comment #2)
> > Update: the problem is still the same, even with the new javascript logger.
> 
> But is probably trivial to "fix" now :).
> I'm not really sure of the "good" behavior. Wouldn't it suck if it becomes
> possible to lose some messages from the log by just looking around in the
> preferences dialog, and checking/unchecking checkboxes without really thinking
> about it (or while still reading the label), and assume that you did nothing
> because you reverted the settings to the way they were before?

This only affects system where preference changes apply instantly and don't need to be confirmed (i.e. affects Linux, doesn't affect Windows, unsure about Macs).
*** Original post on bio 277 at 2011-09-02 11:53:06 UTC ***

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Update: the problem is still the same, even with the new javascript logger.
> > 
> > But is probably trivial to "fix" now :).
> > I'm not really sure of the "good" behavior. Wouldn't it suck if it becomes
> > possible to lose some messages from the log by just looking around in the
> > preferences dialog, and checking/unchecking checkboxes without really thinking
> > about it (or while still reading the label), and assume that you did nothing
> > because you reverted the settings to the way they were before?
> 
> This only affects system where preference changes apply instantly and don't
> need to be confirmed (i.e. affects Linux, doesn't affect Windows, unsure about
> Macs).

All OSes but Windows instant apply: http://mxr.mozilla.org/mozilla-central/source/xulrunner/app/xulrunner.js#49 (this part of the file is copied into all XUL applications).
You need to log in before you can comment on or make changes to this bug.